Skip to content
This repository has been archived by the owner. It is now read-only.

Use package-lock.json #9691

Closed
wants to merge 1 commit into from
Closed

Use package-lock.json #9691

wants to merge 1 commit into from

Conversation

@bbondy
Copy link
Member

bbondy commented Jun 23, 2017

Fix #8283

Auditors: @diracdeltas

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header
Fix #8283

Auditors: @diracdeltas
@bbondy bbondy added this to the 0.19.x (Nightly Channel) milestone Jun 23, 2017
@bbondy bbondy self-assigned this Jun 23, 2017
@bbondy bbondy requested a review from diracdeltas Jun 23, 2017
@bbondy
Copy link
Member Author

bbondy commented Jun 23, 2017

Marking as work in progress until I verify travis is ok with this.

@diracdeltas
Copy link
Member

diracdeltas commented Jun 23, 2017

it looks like Travis has yet to add support for caching dependencies using package-lock travis-ci/travis-ci#7936

@bbondy bbondy closed this Jul 17, 2017
@luixxiul luixxiul mentioned this pull request Jul 31, 2017
@luixxiul luixxiul removed this from the 0.19.x (Beta Channel) milestone Aug 30, 2017
@luixxiul luixxiul mentioned this pull request Aug 30, 2017
4 of 8 tasks complete
@cezaraugusto cezaraugusto deleted the 8283 branch Oct 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.