Skip to content
This repository has been archived by the owner. It is now read-only.

Sync: Fix some tests #9969

Closed
wants to merge 1 commit into from
Closed

Sync: Fix some tests #9969

wants to merge 1 commit into from

Conversation

@ayumi
Copy link
Contributor

ayumi commented Jul 11, 2017

Fix brave/sync#136

No longer using test helper waitForBookmarkDetail.

Test failures were related to 4538db1

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header
@ayumi ayumi self-assigned this Jul 11, 2017
@ayumi ayumi force-pushed the fix/sync-tests-20170711 branch from 18b3a0e to 37ab8fe Jul 12, 2017
Fix brave/sync#136

No longer using test helper waitForBookmarkDetail.

Related to 4538db1
@ayumi ayumi force-pushed the fix/sync-tests-20170711 branch from 37ab8fe to 6c63a1e Jul 12, 2017
@ayumi ayumi changed the title Sync: Fix tests and increase determinism Sync: Fix some tests Jul 12, 2017
@ayumi ayumi closed this Jul 18, 2017
@cezaraugusto cezaraugusto deleted the fix/sync-tests-20170711 branch Oct 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.