Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplacing end of flow learn more link with Brave article #101
Conversation
Adding gulp task for link replacement Removing ConfirmRemoveAccount override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ryanml commentedJan 6, 2020
•
edited
Fixes: brave/brave-browser#7444
The added gulp task makes replacing links in href attributes simpler, as opposed to overriding the entire
rendermethod of: https://github.com/MetaMask/metamask-extension/blob/master/ui/app/pages/first-time-flow/end-of-flow/end-of-flow.component.js#L19