Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upArt52123103 patch 1 #102
Closed
Art52123103 patch 1 #102
Conversation
This is used by brave-core-crx-packager and for testing we can always test with the same extension ID that way
The `brave/app/fonts` directory was copied directly from brave-core.
It doesn't get translated with components
Updating hardware connect icons
Hiding MM secure logo from dialog
Fixing dependency vulnerabilities
Removing mm secure logo from dapp transaction view
Fixing main view overflow
Referencing direct eth-json-rpc-infura hash
Fix brave/brave-browser#6442 Test plan: 1. Submit the wrong password to unlock the wallet 2. It should show an error 3. Submit the correct password 4. It should unlock successfully
Update KeyringController to fix password retry
|
Hi - I'm closing this pull request unless there was something specific trying to be accomplished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Art52123103 commentedJan 7, 2020
No description provided.