Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for Reset Crypto Wallets feature #106

Merged
merged 1 commit into from Feb 26, 2020
Merged

UI for Reset Crypto Wallets feature #106

merged 1 commit into from Feb 26, 2020

Conversation

@ryanml
Copy link
Member

ryanml commented Jan 14, 2020

Partially fixes: brave/brave-browser#5741

Note: This should not be merged until brave/brave-core#4364 is merged and uplifted to appropriate channel.

Screen Shot 2020-01-13 at 6 07 43 PM

Screen Shot 2020-01-13 at 6 07 40 PM

@ryanml ryanml requested a review from bbondy Jan 14, 2020
@ryanml ryanml self-assigned this Jan 14, 2020
@ryanml ryanml force-pushed the reset-crypto-wallets branch 2 times, most recently from f0c529c to 42d6c1c Jan 14, 2020
@ryanml ryanml force-pushed the reset-crypto-wallets branch from 42d6c1c to c6c6d35 Jan 31, 2020
@ryanml ryanml requested a review from bbondy Jan 31, 2020
@ryanml ryanml force-pushed the reset-crypto-wallets branch from c6c6d35 to 624359a Jan 31, 2020
Copy link
Member

bbondy left a comment

The wording makes it sound a bit like we don't understand how Ethereum works, but I'm ok with it.

@ryanml ryanml force-pushed the reset-crypto-wallets branch 2 times, most recently from f6f673b to 42140b3 Feb 6, 2020
@ryanml ryanml mentioned this pull request Feb 17, 2020
8 of 32 tasks complete
@ryanml ryanml force-pushed the reset-crypto-wallets branch from 42140b3 to ed38652 Feb 26, 2020
@ryanml ryanml requested a review from bbondy Feb 26, 2020
@bbondy
bbondy approved these changes Feb 26, 2020
@ryanml ryanml merged commit 1073def into master Feb 26, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@ryanml ryanml deleted the reset-crypto-wallets branch Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.