Skip to content

/ ethereum-remote-client

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for dark mode #109

Merged
merged 1 commit into from Jan 21, 2020
Merged

Adding support for dark mode #109

merged 1 commit into from Jan 21, 2020

Conversation

@ryanml
Copy link
Member

ryanml commented Jan 17, 2020 •
edited

Fixes brave/brave-browser#6381

Screen Shot 2020-01-17 at 2 46 58 PM

Screen Shot 2020-01-17 at 2 46 53 PM

Screen Shot 2020-01-17 at 2 45 01 PM

Screen Shot 2020-01-17 at 2 36 38 PM

Screen Shot 2020-01-17 at 2 35 11 PM

Screen Shot 2020-01-17 at 2 34 32 PM

Screen Shot 2020-01-17 at 2 34 22 PM

Screen Shot 2020-01-17 at 2 34 19 PM

Screen Shot 2020-01-17 at 2 34 14 PM

Screen Shot 2020-01-17 at 2 34 10 PM

Screen Shot 2020-01-17 at 2 34 05 PM

Screen Shot 2020-01-17 at 2 34 01 PM

Screen Shot 2020-01-17 at 2 33 48 PM

Screen Shot 2020-01-17 at 2 33 38 PM

Screen Shot 2020-01-17 at 2 33 33 PM

Screen Shot 2020-01-17 at 2 33 12 PM

Screen Shot 2020-01-17 at 2 33 05 PM

Screen Shot 2020-01-17 at 2 33 00 PM

Screen Shot 2020-01-17 at 2 32 25 PM

Screen Shot 2020-01-17 at 2 32 18 PM

Screen Shot 2020-01-17 at 2 32 08 PM

Screen Shot 2020-01-17 at 2 31 49 PM

Screen Shot 2020-01-17 at 2 31 28 PM

Screen Shot 2020-01-17 at 2 30 51 PM

Screen Shot 2020-01-17 at 2 30 42 PM

Screen Shot 2020-01-17 at 2 30 35 PM
@ryanml ryanml requested a review from bbondy Jan 17, 2020
@ryanml ryanml self-assigned this Jan 17, 2020
@bbondy
Copy link
Member

bbondy commented Jan 20, 2020

This network selector contrast needs some help:
Screen Shot 2020-01-20 at 11 44 46 AM

Contrast on these images for Ledger and Trezor is too bad. @jamesmudgett what do you recommend? Could do lighter buttons perhaps or switch out the image to a white one?
Screen Shot 2020-01-20 at 11 47 38 AM

Ditto on this one:
Screen Shot 2020-01-20 at 11 49 34 AM
@bbondy
bbondy requested changes Jan 20, 2020
View changes
Copy link
Member

bbondy left a comment

Just those main contrast issues I pointed out, I think otherwise the rest is OK.

The Ethereum logo next to numbers doesn't have enough contrast but I think it's not a big deal.
@jamesmudgett
Copy link

jamesmudgett commented Jan 20, 2020

White fill on dark mode (fill will flatten appearance of eth logo but that's OK)
@srirambv srirambv mentioned this pull request Jan 20, 2020
Closed
@ryanml ryanml force-pushed the dark-mode-3 branch from b4bce41 to 2d4d000 Jan 21, 2020
@ryanml
Copy link
Member Author

ryanml commented Jan 21, 2020 •
edited

@bbondy @jamesmudgett feedback addressed:

Screen Shot 2020-01-20 at 5 18 51 PM
Screen Shot 2020-01-20 at 5 13 27 PM
Screen Shot 2020-01-20 at 4 52 23 PM
@ryanml ryanml requested a review from bbondy Jan 21, 2020
@ryanml ryanml mentioned this pull request Jan 21, 2020
Merged
7 of 32 tasks complete
@bbondy
bbondy reviewed Jan 21, 2020
View changes
Copy link
Member

bbondy left a comment

🎉
@ryanml
Adding support for dark mode
Loading status checks…
6694e42
@ryanml ryanml force-pushed the dark-mode-3 branch from 2d4d000 to 6694e42 Jan 21, 2020
@ryanml ryanml merged commit 9578bcd into master Jan 21, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@ryanml ryanml deleted the dark-mode-3 branch Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy

Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Crypto Wallet dark theme issues
3 participants
@ryanml @bbondy @jamesmudgett
You can’t perform that action at this time.