Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixing overflow issues for seed phrase confirmation and dapp connect #113
Conversation
|
|
||
| module.exports = class BraveProviderPageContainer extends ProviderPageContainer { | ||
| componentDidMount () { | ||
| if (getEnvironmentType(window.location.href) !== ENVIRONMENT_TYPE_NOTIFICATION) { |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ryanml commentedJan 31, 2020
Fixes: brave/brave-browser#7882
Fixes: brave/brave-browser#7045
We initially removed the need for
overflow-y: scrollwhen our outer container, housing the Brave Settings header was implemented.There are two exceptions for this, the connect dapp screen and confirm seed phrase screen.
Unfortunately since this is a top level container that does not receive a selector update when screens change, this can not be targeted with CSS.
A good followup upstream would be to actually make these designs resize, however for now this allows users to scroll without the need to zoom out.