Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixing login issues after partial onboarding #114
Conversation
btommm
commented
Feb 10, 2020
Hi, Not sure if this has been fixed @ryanml . I am still having this same issue. |
|
Hey @btommm - this update actually has not been released to the browser, we are aiming for early this week. I plan to issue an update in to issue #6442 when it is. |
btommm
commented
Feb 10, 2020
|
Hi Ryan,
Thank you. Please keep us posted
Best,
…On Sun, Feb 9, 2020 at 10:04 PM ryanml ***@***.***> wrote:
Hey @btommm <https://github.com/btommm> - this update actually has not
been released to the browser, we are aiming for early this week. I plan to
issue an update in to issue #6442 when it is.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#114?email_source=notifications&email_token=AOQMLHUIOWWXREHWYLWHOSTRCDU5BA5CNFSM4KPMDZQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELHKWXQ#issuecomment-583969630>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOQMLHU6DCBYDUWCPLWTMV3RCDU5BANCNFSM4KPMDZQA>
.
|
ryanml commentedFeb 3, 2020
Fixes: brave/brave-browser#6442
Issue here was that given our modified onboarding flow, it was possible to initialize vaults/account without setting the
completedOnboardingflag. This checks for an initialized account without a completed onboarding and sets it so. This will back fix any users who have experienced this issue.Container needed to be overwritten to merge in extra props