Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing login issues after partial onboarding #114

Merged
merged 1 commit into from Feb 4, 2020
Merged

Fixing login issues after partial onboarding #114

merged 1 commit into from Feb 4, 2020

Conversation

@ryanml
Copy link
Member

ryanml commented Feb 3, 2020

Fixes: brave/brave-browser#6442

Issue here was that given our modified onboarding flow, it was possible to initialize vaults/account without setting the completedOnboarding flag. This checks for an initialized account without a completed onboarding and sets it so. This will back fix any users who have experienced this issue.

Container needed to be overwritten to merge in extra props

@ryanml ryanml self-assigned this Feb 3, 2020
@ryanml ryanml changed the title Fixing login error after partial onboarding Fixing login issues after partial onboarding Feb 3, 2020
@ryanml ryanml requested a review from bbondy Feb 3, 2020
@bbondy
bbondy approved these changes Feb 4, 2020
@ryanml ryanml merged commit dc58391 into master Feb 4, 2020
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@ryanml ryanml deleted the login-fix branch Feb 4, 2020
@btommm
Copy link

btommm commented Feb 10, 2020

Fixes: brave/brave-browser#6442

Issue here was that given our modified onboarding flow, it was possible to initialize vaults/account without setting the completedOnboarding flag. This checks for an initialized account without a completed onboarding and sets it so. This will back fix any users who have experienced this issue.

Container needed to be overwritten to merge in extra props

Hi, Not sure if this has been fixed @ryanml . I am still having this same issue.

@ryanml
Copy link
Member Author

ryanml commented Feb 10, 2020

Hey @btommm - this update actually has not been released to the browser, we are aiming for early this week. I plan to issue an update in to issue #6442 when it is.

@btommm
Copy link

btommm commented Feb 10, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.