Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V7.7.5 Upstream Changes #124

Merged
merged 12 commits into from Feb 25, 2020
Merged

V7.7.5 Upstream Changes #124

merged 12 commits into from Feb 25, 2020
Commits on Feb 25, 2020
  1. Update data on Approve screen after updating custom spend limit (#7918)

    Gudahtt authored and ryanml committed Jan 28, 2020
    After updating the custom spend limit on the approve screen, the data
    for the transaction was not being updated. Instead it showed the
    original transaction data. The transaction data was being updated
    correctly in the final transaction though.
    
    The approve screen has been updated to ensure changes to the custom
    spend limit are reflected correctly in the data shown.
  2. Allow editing max spend limit (#7919)

    Gudahtt authored and ryanml committed Jan 29, 2020
    In the case where the initial spend limit for the `approve` function
    was set to the maximum amount, editing this value would result in the
    new limit being silently ignored. The transaction would be submitted
    with the original max spend limit.
    
    This occurred because function to generate the new custom data would
    look for the expected spend limit in the existing data, then bail if
    it was not found (and in these cases, it was never found).
    
    The reason the value was not found is that it was erroneously being
    converted to a `Number`. A JavaScript `Number` is not precise enough to
    represent larger spend limits, so it would give the wrong hex value
    (after rounding had taken place in the conversion to a floating-point
    number).
    
    The data string is now updated without relying upon the original token
    value; the new value is inserted after the `spender` argument instead,
    as the remainder of the `data` string is guaranteed to be the original
    limit. Additionally, the conversion to a `Number` is now omitted so
    that the custom spend limit is encoded correctly.
    
    Fixes #7915
  3. Validate custom spend limit (#7920)

    Gudahtt authored and ryanml committed Jan 29, 2020
    The custom spend limit was previously not validated. It did have a
    minimum of zero set, but this didn't have any affect (that minimum is
    used for form constraint validation, and this field wasn't in a form).
    The field was never checked to ensure the contents didn't exceed the
    maximum.
    
    The field is now checked for values that exceed the maximum, and
    invalid values in general (including negative values).
    
    The parameters to the `showEditApprovalPermissionModal` were also
    alphabetized to make them easier to read. In the course of doing this,
    I noticed that the origin was missing from one of the calls. This was
    responsible for the modal saying "Spend limit requested by undefined"
    when clicking "Edit" under the transaction details. This has been
    fixed.
  4. Only resolve ENS on mainnet (#7944)

    Gudahtt authored and ryanml committed Jan 30, 2020
    The ENS resolver will now bail on any network other than mainnet.
  5. Update ENS registry addresses (#7954)

    whymarrh authored and ryanml committed Jan 30, 2020
  6. Update ethereum-ens-network-map in lockfile (#7959)

    whymarrh authored and ryanml committed Jan 30, 2020
    * Update yarn.lock cross-spawn versions
    * Use ethereum-ens-network-map@1.0.2
  7. Add warning to watchAsset API when editing a known token (#8049)

    danfinlay authored and ryanml committed Feb 14, 2020
    * Add warning when editing a known token with watchAsset API
    
    * Add warning when watchAsset attempts to reuse token symbol
  8. Update Wyre ETH purchase url (#8051)

    Gudahtt authored and ryanml committed Feb 14, 2020
    * Revert "Revert "Update Wyre ETH purchase url" (#7631)"
    
    This reverts commit bc67d1eecabb123bf21445e604780d2454d52d3e.
    
    * Restrict widget to just debit card payments
    
    Apple Pay apparently only works on Safari.
  9. Attempt ENS resolution on any valid domain name (#8059)

    Gudahtt authored and ryanml committed Feb 18, 2020
    ENS currently supports a variety of tlds in addition to `.eth`, and
    more will be supported in the future. Rather than hard-code a list of
    supported ENS tlds, all valid domain names will now be interpreted as
    potential ENS addresses in our address input component.
    
    Closes #7978
You can’t perform that action at this time.