Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdding Brave Header component #2
Merged
Conversation
|
can't comment on design, but this lgtm security-wise |
ryanml
force-pushed the
toolbar-updates
branch
3 times, most recently
from
c3b0166
to
e6fa25a
| @@ -0,0 +1,100 @@ | |||
| .br-toolbar { | |||
This comment has been minimized.
This comment has been minimized.
bbondy
Jun 11, 2019
Member
Can we have things in a single top level brave folder with the same duplicated hierarchy?
app/home.html
Outdated
| @@ -3,7 +3,7 @@ | |||
| <head> | |||
| <meta charset="utf-8"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1 user-scalable=no"> | |||
| <title>MetaMask</title> | |||
| <title>Brave Wallet</title> | |||
This comment has been minimized.
This comment has been minimized.
bbondy
Jun 11, 2019
Member
I think we can do this with webpack as part of the branding too. I think you can split this and the manifest.json out of this PR.
ryanml
force-pushed the
toolbar-updates
branch
2 times, most recently
from
f22f488
to
7f7b483
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ryanml commentedJun 6, 2019
•
edited
This pull request does a few things ahead of the initial packaging in to the browser:
A consideration to make about the extension popup is that even if this isn't specified, the browser will still add a grayed out icon to the toolbar for visibility (sec issue, we will probably have to override this from within chromium)