Skip to content

/ ethereum-remote-client

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Eth Wallet header from onboarding flow, main view #22

Merged
merged 1 commit into from Jul 9, 2019
Merged

Removing Eth Wallet header from onboarding flow, main view #22

merged 1 commit into from Jul 9, 2019

Conversation

@ryanml
Copy link
Member

ryanml commented Jul 4, 2019 •
edited

Fixes: brave/brave-browser#5108

Also removed some now unneeded code
@ryanml ryanml requested a review from bbondy Jul 4, 2019
@ryanml ryanml self-assigned this Jul 4, 2019
@bbondy
Copy link
Member

bbondy commented Jul 4, 2019

What do you think about upstreaming a refactor to use a component for the header?
@ryanml ryanml force-pushed the master branch 4 times, most recently from 5e9041c to 3defc26 Jul 9, 2019
@ryanml ryanml force-pushed the fix-5108 branch from 45f4f60 to 12e2170 Jul 9, 2019
@ryanml
Removing metafox logo from app header, onboarding process
Loading status checks…
cd7e41b 
2
@ryanml ryanml force-pushed the fix-5108 branch from 12e2170 to cd7e41b Jul 9, 2019
@ryanml
Copy link
Member Author

ryanml commented Jul 9, 2019

Upstream change pulled in: 8d457e0 - PR rebased
@bbondy
bbondy approved these changes Jul 9, 2019
View changes
@bbondy bbondy merged commit 0403c3e into master Jul 9, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy

Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Remove ETH Wallet header
2 participants
@ryanml @bbondy
You can’t perform that action at this time.