Skip to content

/ ethereum-remote-client

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing MM TOS from onboarding, settings #24

Merged
merged 1 commit into from Jul 11, 2019
Merged

Removing MM TOS from onboarding, settings #24

merged 1 commit into from Jul 11, 2019

Conversation

@ryanml
Copy link
Member

ryanml commented Jul 11, 2019 •
edited

Fixes: brave/brave-browser#5223

Screen Shot 2019-07-10 at 6 31 52 PM

Screen Shot 2019-07-10 at 6 31 47 PM

Screen Shot 2019-07-10 at 6 31 32 PM
@ryanml ryanml requested a review from bbondy Jul 11, 2019
@ryanml ryanml self-assigned this Jul 11, 2019
@bbondy
Copy link
Member

bbondy commented Jul 11, 2019

This is a lot of copied code, can we avoid it? Like maybe use CSS to hide it but default it to checked.
@ryanml ryanml force-pushed the remove-mm-tos branch from 7db4594 to aca3dd7 Jul 11, 2019
@ryanml
Copy link
Member Author

ryanml commented Jul 11, 2019

@bbondy done
@ryanml
Removing MM TOS from onboarding, settings
Loading status checks…
653755c
@ryanml ryanml force-pushed the remove-mm-tos branch from aca3dd7 to 653755c Jul 11, 2019
@bbondy
bbondy approved these changes Jul 11, 2019
View changes
@ryanml ryanml merged commit 9d040c2 into master Jul 11, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@ryanml ryanml deleted the remove-mm-tos branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy

Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Remove TOS checkboxes from onboarding process, settings page in crypto wallet
2 participants
@ryanml @bbondy
You can’t perform that action at this time.