Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly opening new tab on dapp request for unitialized wallets #25
Conversation
| if (hasOnboarded) { | ||
| this.optsOpenPopup() | ||
| } else { | ||
| chrome.tabs.create({ url: 'home.html' }) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bbondy
Jul 11, 2019
Member
You can try, I'm ok if it works. I had seen that if you try to load the chrome-extension URL directly it doesn't show the Brave icon and verified brave page, but if you do use the chrome:// URL which shows as brave:// it does. If it works like you have it oh master though, then that's cool.
This comment has been minimized.
This comment has been minimized.
ryanml
Jul 11, 2019
Author
Member
Updated this to chrome://wallet/home.html, seems that you don't get the brave page items without it, as you said.
One thing to keep in mind is that MM does use the relative path to open windows and views, so this may be something to go through and update across the board as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ryanml commentedJul 11, 2019
This adds a proxy to the passed
openPopupmethod forProviderApprovalControllerProvider approval requests will just open the welcome page in a new tab for users who have not onboarded/started MM, and will not attempt to create a notification
Provider approval functions as expected once user has created an account