Skip to content

/ ethereum-remote-client

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'browser wallet' -> 'local wallet' #26

Merged
merged 1 commit into from Jul 11, 2019
Merged

'browser wallet' -> 'local wallet' #26

merged 1 commit into from Jul 11, 2019

Conversation

@ryanml
Copy link
Member

ryanml commented Jul 11, 2019

Screen Shot 2019-07-11 at 12 24 05 AM
@ryanml
browser wallet -> local wallet
Loading status checks…
7b6d5ac
@ryanml ryanml requested a review from bbondy Jul 11, 2019
@ryanml ryanml self-assigned this Jul 11, 2019
@bbondy
bbondy approved these changes Jul 11, 2019
View changes
@bbondy
bbondy reviewed Jul 11, 2019
View changes
brave/ui/app/components/app/connect-wallet/connect-wallet.component.js
title: 'New Browser Wallet',
subText: 'Create a new Brave browser wallet to access dApps and store crypto and collectibles securely. Trade tokens annonymously with no trading fees.',
title: 'New Local Wallet',
subText: 'Create a new Brave local wallet to access dApps and store crypto and collectibles securely. Trade tokens annonymously with no trading fees.',

This comment has been minimized.

Sign in to view
Copy link
@bbondy

bbondy Jul 11, 2019

Member

btw shouldn't these be localized?
@ryanml ryanml merged commit bafb707 into master Jul 11, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@ryanml ryanml deleted the wallet-text-update branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy

Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ryanml @bbondy
You can’t perform that action at this time.