Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdating Infura Endpoints -> Brave #33
Merged
Conversation
ryanml
force-pushed the
brave-infura
branch
2 times, most recently
from
3c17bfa
to
e7710ae
| const parsedResponse = await response.json() | ||
|
|
||
| this.store.updateState({ | ||
| infuraNetworkStatus: parsedResponse, |
This comment has been minimized.
This comment has been minimized.
ryanml
force-pushed the
brave-infura
branch
2 times, most recently
from
dca8f40
to
9ec9fb8
ryanml
changed the title
package.json
Outdated
| @@ -95,7 +95,7 @@ | |||
| "eth-ens-namehash": "^2.0.8", | |||
| "eth-hd-keyring": "^1.2.2", | |||
| "eth-json-rpc-filters": "^3.0.4", | |||
| "eth-json-rpc-infura": "^3.2.0", | |||
| "eth-json-rpc-infura": "github:brave-experiments/eth-json-rpc-infura#master", | |||
This comment has been minimized.
This comment has been minimized.
ryanml
Aug 2, 2019
Author
Member
For now the project id can be hardcoded from in here for testing this PR
This comment has been minimized.
This comment has been minimized.
bbondy
Aug 3, 2019
Member
I don't think you need to specify the branch name if it's master and master is the default branch
ryanml
force-pushed the
brave-infura
branch
4 times, most recently
from
cb95029
to
e870b6b
bbondy
force-pushed the
fix/key-gen
branch
2 times, most recently
from
8bd3547
to
149bb25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ryanml commentedJul 30, 2019
No description provided.