Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make scss import injection robust #34

Merged
merged 1 commit into from Jul 30, 2019
Merged

make scss import injection robust #34

merged 1 commit into from Jul 30, 2019

Conversation

@cg505
Copy link
Contributor

cg505 commented Jul 30, 2019

This creates a more robust method for injecting our SCSS imports. The old method will be broken when the file that we are injecting into changes. This method does not rely on any knowledge of the file.

This creates a more robust method for injecting our SCSS imports. The
old method will be broken when the file that we are injecting into
changes. This method does not rely on any knowledge of the file.
@cg505 cg505 requested review from bbondy and ryanml Jul 30, 2019
@ryanml
ryanml approved these changes Jul 30, 2019
Copy link
Member

ryanml left a comment

++ thnx for this one

@ryanml ryanml merged commit 4bd59fa into master Jul 30, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@ryanml ryanml deleted the robust-load-styles branch Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.