Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixing wallet import function on login page #52
Merged
Conversation
| @@ -156,7 +156,7 @@ const createBraveReplacePathsTask = () => { | |||
| ) | |||
| .pipe( | |||
| replace( | |||
| /'(.*)\/restore-vault'/gm, | |||
| /'(.*)\/keychains\/restore-vault'/gm, | |||
This comment has been minimized.
This comment has been minimized.
ryanml
Aug 15, 2019
Author
Member
This regex was too general, it would override the route constant on: https://github.com/brave/ethereum-remote-client/blob/master/ui/app/helpers/constants/routes.js#L19
| @@ -1,6 +1,12 @@ | |||
| import RestoreVaultPage from '../../../../../ui/app/pages/keychains/restore-vault' | |||
| const RestoreVaultPage = require('../../../../../ui/app/pages/keychains/restore-vault').default.WrappedComponent | |||
This comment has been minimized.
This comment has been minimized.
ryanml
Aug 15, 2019
•
Author
Member
The issue here is what was being extended before was not a react class, but the entire connected component (https://github.com/brave/ethereum-remote-client/blob/master/ui/app/pages/keychains/restore-vault.js#L190)
Since the above MM component doesn't have a separate container file to override, all we can do is extract the WrappedComponent which contains the class we want to extend, and then re-connect it.
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ryanml commentedAug 15, 2019
Fixes: brave/brave-browser#5682