Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to latest eth-hd-keyring #77
Merged
Conversation
| @@ -85,7 +85,6 @@ | |||
| "eth-block-tracker": "^4.1.0", | |||
| "eth-contract-metadata": "^1.9.2", | |||
| "eth-ens-namehash": "^2.0.8", | |||
| "eth-hd-keyring": "github:brave/eth-hd-keyring", | |||
This comment has been minimized.
This comment has been minimized.
diracdeltas
Oct 3, 2019
Author
Member
not sure why this is here in the first place since eth-hd-keyring is only used as a dependency of eth-keyring-controller AFAICT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
diracdeltas commentedOct 3, 2019
This should fix brave/brave-browser#5698
Test plan (after
yarn dev:braveto build and load in brave):