Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest eth-hd-keyring #77

Merged
merged 2 commits into from Oct 3, 2019
Merged

Update to latest eth-hd-keyring #77

merged 2 commits into from Oct 3, 2019

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented Oct 3, 2019

This should fix brave/brave-browser#5698

Test plan (after yarn dev:brave to build and load in brave):

  1. click restore
  2. enter 'phrase upgrade clock rough situate wedding elder clever doctor stamp excess tent' for the code words
  3. address should be 0x6858DC3A3E1c2F4de7dA740bb0257ED8A0aE582b
  4. log out
  5. log in with password, see same address
  6. log out again
  7. now select 'Import using account seed phrase'
  8. enter phrase from step 2
  9. it should restore the same address
  10. give yourself some eth using https://faucet.rinkeby.io/ (make sure you are on rinkeby testnet)
  11. the eth should show up in your account
  12. transfer eth to 0xE53d989B8f69A2dBAbACf5CB23c186Cf5Ae0fb61
  13. the transfer should work
@diracdeltas diracdeltas requested a review from bbondy Oct 3, 2019
@@ -85,7 +85,6 @@
"eth-block-tracker": "^4.1.0",
"eth-contract-metadata": "^1.9.2",
"eth-ens-namehash": "^2.0.8",
"eth-hd-keyring": "github:brave/eth-hd-keyring",

This comment has been minimized.

Copy link
@diracdeltas

diracdeltas Oct 3, 2019

Author Member

not sure why this is here in the first place since eth-hd-keyring is only used as a dependency of eth-keyring-controller AFAICT

@diracdeltas diracdeltas self-assigned this Oct 3, 2019
@bbondy
bbondy approved these changes Oct 3, 2019
@diracdeltas diracdeltas merged commit a672a54 into master Oct 3, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.