Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using translated strings on welcome page #78

Merged
merged 1 commit into from Oct 8, 2019
Merged

Using translated strings on welcome page #78

merged 1 commit into from Oct 8, 2019

Conversation

@ryanml
Copy link
Member

ryanml commented Oct 5, 2019

@ryanml ryanml requested review from bbondy and cg505 Oct 5, 2019
@ryanml ryanml self-assigned this Oct 5, 2019
@ryanml ryanml force-pushed the fix-6308 branch from 96fbf18 to 173db6b Oct 5, 2019
@@ -5,15 +5,24 @@
"braveRewards": {
"message": "Brave Rewards"
},
"connect": {

This comment has been minimized.

Copy link
@ryanml

ryanml Oct 5, 2019

Author Member

This was present in translations upstream, but just did not appear to have a russian translation entry for it. I've included it here so it gets included in our next transifex round

@@ -26,15 +35,18 @@
"passWarningTwo": {
"message": "before using this tool."
},
"restore": {

This comment has been minimized.

Copy link
@ryanml

ryanml Oct 5, 2019

Author Member

Ditto

@bbondy
bbondy approved these changes Oct 8, 2019
@bbondy bbondy merged commit de05b52 into master Oct 8, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@ryanml ryanml deleted the fix-6308 branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.