Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version and yarn install causes yarn.lock update #79

Merged
merged 2 commits into from Oct 7, 2019

Conversation

@bbondy
Copy link
Member

bbondy commented Oct 7, 2019

No description provided.

bbondy added 2 commits Oct 7, 2019
@bbondy bbondy requested a review from diracdeltas Oct 7, 2019
version "2.0.0"
resolved "https://codeload.github.com/brave/eth-hd-keyring/tar.gz/b6cf593fc77572a313f101b1e691a68b333a63dd"
dependencies:
bip39 "^3.0.2"

This comment has been minimized.

Copy link
@diracdeltas

diracdeltas Oct 7, 2019

Member

not so sure about why this is here since eth-hd-keyring@ b6cf593fc77572a313f101b1e691a68b333a63dd does require bip39; maybe because keyringcontroller already has a bip39 dep. let's try it and see.

@diracdeltas
Copy link
Member

diracdeltas commented Oct 7, 2019

merging since i get this diff too now

@diracdeltas diracdeltas merged commit 899c406 into master Oct 7, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@diracdeltas diracdeltas deleted the update-version branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.