Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin to specific version of keyringcontroller #81

Merged
merged 1 commit into from Oct 8, 2019
Merged

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented Oct 7, 2019

for some reason, without this yarn will still install the older version of eth-hd-keyring instead of latest master.

test plan:

  1. restore from invite deer vivid fun attract sunny leave endless mutual teach around apology
  2. resulting wallet address should be 0xee3B1E721B39E99B4Bce4491CAD4db92602948F1
@diracdeltas diracdeltas requested a review from bbondy Oct 7, 2019
@diracdeltas diracdeltas force-pushed the update/eth-keyring2 branch 2 times, most recently from 6eb0e03 to 9d281a0 Oct 7, 2019
otherwise sometimes yarn will install an out-of-date version
@diracdeltas diracdeltas force-pushed the update/eth-keyring2 branch from 9d281a0 to f2ad924 Oct 8, 2019
@diracdeltas diracdeltas self-assigned this Oct 8, 2019
@bbondy
bbondy approved these changes Oct 8, 2019
@bbondy bbondy merged commit 2224dd0 into master Oct 8, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.