Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update KeyringController to fix password retry #91

Merged
merged 1 commit into from Dec 8, 2019
Merged

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented Dec 4, 2019

Fix brave/brave-browser#6442

Test plan:

  1. Submit the wrong password to unlock the wallet
  2. It should show an error
  3. Submit the correct password
  4. It should unlock successfully
@diracdeltas diracdeltas requested a review from ryanml Dec 4, 2019
@diracdeltas diracdeltas self-assigned this Dec 4, 2019
Fix brave/brave-browser#6442

Test plan:
1. Submit the wrong password to unlock the wallet
2. It should show an error
3. Submit the correct password
4. It should unlock successfully
@diracdeltas diracdeltas force-pushed the fix/keyring-relock branch from c4bd8e2 to cf555c8 Dec 4, 2019
@ryanml
ryanml approved these changes Dec 4, 2019
@ryanml ryanml merged commit 3f552e5 into master Dec 8, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@ryanml ryanml deleted the fix/keyring-relock branch Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.