Skip to content

/ extension-whitelist

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parser #23

Open
wants to merge 5 commits into
base: master
from
Open

Refactor parser #23

wants to merge 5 commits into from
Commits on Apr 21, 2020

  1. Refactor code assuming buffer is 32 bytes

    @keur
    keur committed Feb 20, 2020 
    This is a safe assumption to make.

https://support.google.com/chrome/a/answer/7532015?hl=en
    11ee1ad

  2. Simplify whitelist data serialization

    @keur
    keur committed Feb 20, 2020 
    Every extension ID that needs be serialized is 32 bytes. No longer
necessary to embed the length of each extension in the serialized
buffer.
    3d484e1

  3. extension_whitelist_parser: safely serialize uint32_t

    @keur
    keur committed Feb 20, 2020 
    Include inttypes.h to format width-based integral types. This is safer
than %x, because %x may read an unbounded amount of characters.
    4aee155

  4. Refactor with std functions

    @keur
    keur committed Apr 5, 2020 
      * Replace ST_EXTENSION_WHITELIST_DATA with std::string
  * Replace hash-set.cpp with std::unordered_set
    ec8ed6e
Commits on Apr 22, 2020

  1. Review fixups

    @keur
    keur committed Apr 21, 2020 
      * Use strings where possible
  * Replace DECIMAL_STRING_MAX WITH UINT32_SERIALIZE_MAX since we are
    only serializing uint32_t
  * Remove extension_set class and make Serialize and Deserialize free
    functions
    752fd7b
You can’t perform that action at this time.