Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chromium version to determine AdBlock version #23

Open
jumde opened this issue Feb 28, 2019 · 0 comments
Open

Use chromium version to determine AdBlock version #23

jumde opened this issue Feb 28, 2019 · 0 comments
Assignees

Comments

@jumde
Copy link
Contributor

@jumde jumde commented Feb 28, 2019

For example ad-block is currently on format v4. That's where this 4 comes from in:
~/Library/Application\ Support/BraveSoftware/Brave-Browser-Beta/cffkpbalmllkdoenhmdmpbkajipdjfam/1.0.133/4/ABPFilterParserData.dat

The Brave Browser is smart enough to know to update the extension to v5 if it has client code from brave/ad-block that specifies the current version as v5 format.

The problem is, we need to go to version 5 format soon. This wouldn't be a problem for it landing in master only. But to do this we need to be able to keep old installs still working.

we'd want the ability to update extensions differently depending on the Chromium version in use.

So mainly we'd like to have the ability to have Chromium 73 and below use a differently packaged format v4 extension. And Chromium 74 and above use a differently packaged format v5 extension. Both would keep the same extension ID.

This would need changes for both brave/brave-core-crx-packager and brave/go-update. Mainly we'd just coordinate ad-block format updates on major chromium update releases so it works out nicely.

@jumde jumde self-assigned this Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.