Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIssue 18: Use dev instances of S3 buckets for components in dev environments #19
Conversation
…onments Hardcoding production S3 bucket host in the go-updater code causes problems in dev environments. This change uses `S3_EXTENSIONS_BUCKET_HOST` env variable to figure out where the resources are available.. auditors: @bbondy, @hspencerjr, @mihaiplesa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jumde commentedFeb 19, 2019
•
edited
Description
Hardcoding production S3 buckets in the go-updater code causes problems in dev environments. This change uses
S3_EXTENSIONS_BUCKET_HOSTenvironment variable to check ifgo-updateris running in production or development environment.Prod
S3_EXTENSIONS_BUCKET_HOST:brave-core-ext.s3.brave.comDev
S3_EXTENSIONS_BUCKET_HOST:brave-core-ext.s3.bravesoftware.comauditors: @bbondy, @hspencer77, @mihaiplesa
Test Plan
Automated tests should pass.