Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always build HTTPSE with the latest rulesets, fix #7 #12

Merged
merged 3 commits into from Jan 23, 2019

Conversation

@cschanaj
Copy link
Contributor

cschanaj commented Jan 15, 2019

No description provided.

@cschanaj cschanaj changed the title Always build HTTPSE with the latest ruleset versions, fix #7 Always build HTTPSE with the latest rulesets, fix #7 Jan 15, 2019
cschanaj added 2 commits Jan 15, 2019
@diracdeltas diracdeltas self-requested a review Jan 18, 2019
throw err
} else {
let timestamp = ''
let baseURL = 'https://www.https-rulesets.org/v1/'

This comment has been minimized.

Copy link
@diracdeltas

diracdeltas Jan 18, 2019

Member

does EFF guarantee that the rulesets published under v1 will be compatible with HTTPSE'2018.9.19' ? i assume so but just checking because they've done a few updates in the past where the format has changed (and so auto-updating would have broken Brave).

otherwise this approach looks great

This comment has been minimized.

Copy link
@cschanaj

cschanaj Jan 18, 2019

Author Contributor

The v1 directory was added as per EFForg/https-everywhere#14907 (comment) and EFForg/https-everywhere#14907 (comment), so I assume there shouldn't be breaking changes in the rulesets format. Maybe @Hainish @zoracon from EFF can help guarantee that?

@diracdeltas
Copy link
Member

diracdeltas commented Jan 19, 2019

@bsclifton when you get a chance, please merge this and upload the new HTTPS Everywhere rulesets. Thanks

@bsclifton bsclifton merged commit 8d5a625 into brave:master Jan 23, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@cschanaj cschanaj deleted the cschanaj:fix-7 branch Jan 23, 2019
fmarier added a commit to fmarier/https-everywhere-builder that referenced this pull request Jan 24, 2019
There is no need to bump the XPI version number anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.