Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReturn an error when the promises are rejected (fixes #16) #17
Conversation
|
The Travis CI build error is not due to this PR: brave/devops#1057 |
|
got some errors running the steps that are supposed to run via CI Can you fix the lint errors (ex: test with Besides that, there's also an npm audit fix we can run... I'll do a commit updating that |
|
Lint clean and rebased on top of the latest master. |
|
Changes look great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fmarier commentedMay 22, 2019
This is to ensure that our failed Jenkins jobs are actually flagged as failed.