Skip to content

/ https-everywhere-builder

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm update, ignore rules with broken tests #2

Merged
merged 2 commits into from Nov 1, 2017
Merged

npm update, ignore rules with broken tests #2

merged 2 commits into from Nov 1, 2017

Conversation

@diracdeltas
Copy link
Member

diracdeltas commented Oct 28, 2017

fix brave/browser-laptop#10586
diracdeltas added 2 commits Oct 28, 2017
@diracdeltas
run npm update
297f85b
@diracdeltas
Add docs, ignore rules with failed ruleset tests
713a77c 
Fix brave/browser-laptop#10586
@diracdeltas diracdeltas self-assigned this Oct 28, 2017
@diracdeltas diracdeltas requested review from bbondy and bsclifton Oct 28, 2017
@diracdeltas
Copy link
Member Author

diracdeltas commented Nov 1, 2017

can someone merge and npm run upload on this? we keep getting complaints that thehill.com is broken.
@bbondy
bbondy approved these changes Nov 1, 2017
View changes
@bbondy bbondy merged commit 116c5c9 into master Nov 1, 2017
@bbondy
Copy link
Member

bbondy commented Nov 1, 2017

merged and ran build and upload
@bsclifton bsclifton deleted the update/2 branch Nov 3, 2017
@bsclifton
Copy link
Member

bsclifton commented Nov 3, 2017

@diracdeltas sorry about missing this- thanks for knocking it out, @bbondy 😄 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy

@bsclifton bsclifton

Assignees

@diracdeltas diracdeltas

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

thehill.com is inaccessible
3 participants
@diracdeltas @bbondy @bsclifton
You can’t perform that action at this time.