Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse aws-sdk directly insted of through s3client (fixes #35) #39
Conversation
The s3client module is unmaintained and indirectly depends on a vulnerable version of the minimist module. Since it already depends on the aws-sdk module, this change means we can remove a number of dependencies without loss of functionality.
| // See: http://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/Config.html#constructor-property | ||
| s3Options: {} | ||
| const client = new aws.S3({ | ||
| maxRetries: 3, |
This comment has been minimized.
This comment has been minimized.
fmarier
Apr 13, 2020
Author
Member
I wasn't able to find all of the old options since the API has changed significantly. It's not clear to me that they are needed though.
No, it was pretty straightforward. I just had to create the bucket that the upload script is looking for ahead of time and make it public. |
|
I manually updated from 1.0.15 to 1.0.16 and confirmed that https://https-everywhere.badssl.com/ works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fmarier commentedApr 13, 2020
The s3client module is unmaintained and indirectly depends on a vulnerable version of the minimist module. Since it already depends on the aws-sdk module, this change means we can remove a number of dependencies without loss of functionality.
I tested uploads manually using my own AWS account, but I will also trigger a manual rebuild in Jenkins once this is merged and confirm that it works.