Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty exclusion list #4

Merged
merged 13 commits into from Sep 17, 2018
Merged

Empty exclusion list #4

merged 13 commits into from Sep 17, 2018

Conversation

@Bisaloo
Copy link
Contributor

Bisaloo commented Feb 16, 2018

@Bisaloo
Copy link
Contributor Author

Bisaloo commented Feb 16, 2018

@diracdeltas, should the whitelist just be emptied or completely removed alongside related code?

@Bisaloo Bisaloo changed the title [WIP] Empty exclusion list Empty exclusion list Feb 18, 2018
@cschanaj
Copy link
Contributor

cschanaj commented Mar 26, 2018

@diracdeltas it might worth merging this and update the ruleset to 2018.4.2 when a new release is made in EFForg/https-everywhere/issues/14907

@diracdeltas
Copy link
Member

diracdeltas commented May 10, 2018

Sorry for the delay - I will take a look at this next time we update our HTTPS Everywhere version

@diracdeltas diracdeltas self-requested a review Sep 10, 2018
@diracdeltas
Copy link
Member

diracdeltas commented Sep 10, 2018

needs rebase but otherwise lgtm. sorry for dropping the ball on this.

Bisaloo added 13 commits Feb 16, 2018
Fixed server side
Fixed server side
Fixed server side: nikeplus.com now redirects to nike.com
Fixed server side
Fixed server side. Site is now preloaded.
Fixed server side
Fixed server side. Further ruleset cleanup in EFForg/https-everywhere#14651
Fixed server side. See EFForg/https-everywhere#4615
@Bisaloo Bisaloo force-pushed the Bisaloo:patch-1 branch from 9ea5258 to c3d8efc Sep 15, 2018
@Bisaloo
Copy link
Contributor Author

Bisaloo commented Sep 15, 2018

@diracdeltas, I rebased my changes on top of master. It should be okay now.

@diracdeltas diracdeltas merged commit 5ace2ca into brave:master Sep 17, 2018
@diracdeltas
Copy link
Member

diracdeltas commented Sep 17, 2018

thanks!

@Bisaloo Bisaloo deleted the Bisaloo:patch-1 branch Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.