Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release build only as a default #15

Merged
merged 1 commit into from Nov 7, 2018
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -16,7 +16,7 @@ def FetchThirdParties(args, omaha_dir):
command = ['git', 'submodule', 'update', '--init']
sp.check_call(command, stderr=sp.STDOUT)

def Build(args, omaha_dir):
def Build(args, omaha_dir, build_all):
# move to omaha/omaha and start build.
os.chdir(os.path.join(omaha_dir, 'omaha'))

@@ -25,15 +25,18 @@ def Build(args, omaha_dir):
key_cer_path = os.environ.get('KEY_CER_PATH', '')
authenticode_password = os.environ.get('AUTHENTICODE_PASSWORD', '')

command = ['hammer-brave.bat', 'MODE=all', '--all', '--sha2_authenticode_file=' + key_pfx_path,
mode = 'opt-win'
if build_all:
mode = 'all'
command = ['hammer-brave.bat', 'MODE=' + mode, '--all', '--sha2_authenticode_file=' + key_pfx_path,
'--sha2_authenticode_password=' + authenticode_password, '--sha1_authenticode_file=' + key_pfx_path,
'--sha1_authenticode_password=' + authenticode_password, '--patching_certificate=' + key_cer_path,
'--authenticode_file=' + key_pfx_path, '--authenticode_password=' + authenticode_password]

sp.check_call(command, stderr=sp.STDOUT)

def PrepareStandalone(args, omaha_dir):
# copy brave installer to staing folder to create standalond installer.
# copy brave installer to create standalond installer.
installer_file = os.path.join(args.root_out_dir[0], args.brave_installer_exe[0])
shutil.copyfile(installer_file, os.path.join(omaha_dir, 'omaha', 'standalone', args.brave_installer_exe[0]))

@@ -125,9 +128,7 @@ def Main(args):

FetchThirdParties(args, omaha_dir)
PrepareStandalone(args, omaha_dir)
Build(args, omaha_dir)
# Create both(debug/release) executables
Tagging(args, omaha_dir, True)
Build(args, omaha_dir, False)
Tagging(args, omaha_dir, False)

return 0
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.