Skip to content

/ omaha

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signing server error #24

Merged
merged 2 commits into from Jul 11, 2019
+1 −1
Merged

Fix signing server error #24

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2800dac
Fix signing server error
mbacchi Jul 11, 2019
8e9f0f3
Spacing mini-fix
mbacchi Jul 11, 2019
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Fix signing server error 

We already use the Digicert timestamp server in brave builds
but need to also update it here as that might not pass down.
  • Loading branch information
@mbacchi
mbacchi committed Jul 11, 2019
Verified
This commit was signed with a verified signature.
mbacchi Matt Bacchi
GPG key ID: 9009221AE2C5ED52 Learn about signing commits
commit 2800daca0195c2c5f86cbf1dbb5bb01b28e5b8db
2 omaha/hammer-brave.bat
View file
Open in desktop
@@ -35,7 +35,7 @@ goto set_env_variables
:set_env_variables

:: Set signtool arguments
set SIGNTOOL_ARGS="sign /t http://timestamp.verisign.com/scripts/timstamp.dll /fd sha256 /sm"
set SIGNTOOL_ARGS="sign /t http://timestamp.digicert.com /fd sha256 /sm"

This comment has been minimized.

Sign in to view
Copy link
@mihaiplesa

mihaiplesa Jul 11, 2019

Collaborator

are the double spaces needed here?

:: Change these variables to match the local build environment.

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.