WIP: Rebase omaha #25

simonhong · 2019-07-18T05:57:51Z

I think this branch should become master after renaming current master.
Rebased branch can't be merged onto master.


        Update DeveloperSetupGuide.md

Corrected registry path for UpdateDev for 32-bit process usage


        Fixed Spelling.


        Fixed Spelling.


        Trivial tyop fix.


        Merge pull request #139 from da4089/patch-1

Trivial tyop fix.


        fingerprint→fp in SeverProtocolDocV3


        Integrate from Omaha mainline up to 226393814.


        Update CHANGELOG.txt


        Update DeveloperSetupGuide.md


        Merge pull request #137 from jimmycasey/master

Fixed Spelling.


        Merge pull request #129 from patmanpm/patch-1

Update DeveloperSetupGuide.md


        Update README.md

Fixed markup.


        DeveloperSetupGuide.md protobuf version required.

A dependency on 'protobuf/implicit_weak_message.cc' was added on PR 441e209. This file only exists on protobuf version 3.6.0 and higher and user older versions (which used to work before) now causes a build break. This pull request updates the guide to specify the new requirement.


        Merge pull request #141 from hologramas/patch-1

DeveloperSetupGuide.md protobuf version required.


        Added missing ApplyTag.exe


        Define NTDDI_VERSION correctly

`NTDDI_VERSION` was defined in CPPDEFINES as `DNTDDI_VERSION`. The D prefix would be valid for CPPFLAGS, but not here.


        Set WIN_VER and _WIN32_WINNT to 0x0502

Set WIN_VER to _WIN32_WINNT_WS03 (0x0502) Add missing _WIN32_WINNT define. This targets "Windows XP with Service Pack 2 (SP2)".


        Merge pull request #145 from macqm/master

Define NTDDI_VERSION correctly


        Merge pull request #1 from google/master

Merge pull request #145 from macqm/master


        Update DeveloperSetupGuide required tools


        Set WINVER and _WIN32_WINNT to _WIN32_WINNT_WIN7


        Update docs to instruct to use python 2.7


        Merge pull request #147 from macqm/use_python_27

Use python 27


        Merge pull request #146 from macqm/fix_winver

Update WINVER to Windows 7 value.


        commit at CL 239258006


        Merge branch 'master' of https://github.com/google/omaha


        Update CHANGELOG.txt CL 239101811 (Omaha 1.3.34.7)

Notable changes here include adding support for unpacking CRX files, making "Code Red" more secure by wrapping the payload in a CRX container, and fixing a race condition where the /ua process may hang on shutdown during a program update.


        Update CHANGELOG.txt


        Update DeveloperSetupGuide.md

Added libzip 1.3.0 and zlib 1.2.11 to third-party dependencies.


        Merge pull request #149 from GitHubGanesh/patch-2

Update DeveloperSetupGuide.md


        Update cup key for unofficial release


        Store original path to registry to deliver promocode to installer


        Update help url

Set support.brave.com as a help url.


        Updated with customizations and signing-related changes


        Integrate omaha to brave_core

* Remove invalid third_party index and add .gitmodules * Create omaha target * Build stub/standalone installer with tagging


        Make omaha build w/o admin priv

It turns out that enterprise module only needs admin priv. Brave doesn't used it. So it is excluded from build dir list.


        Pass cert and password parameters to hammer-brave.bat

Fixes brave/brave-browser#1990


        Use default 'prefers' for needsadmin tag in standalone installer.


        Remove unused CLI arg


        Make release build only as a default

Build all(release/debug) can take a long build time.


        Create silent/untagged stub and standalone installers

This is part of the work for issue: brave/brave-browser#2210


        Introduce silent tag for silent installer

When silent tag is added in tag list, "/silent /install" is added to command line by metainstaller. silent tag should be added at last of tag list.


        Send stats ping during startup, download, and installation


        Fix stats ping

The download-complete/installer-run stats pings weren't being sent when the stub installer was run in admin mode. This was due to us storing the app guid in the registry, as it is written to a different location when running as an admin vs a regular user. Fixed this by fetching app guid from tag instead. In addition, we append the referral code to the tag sent to the installer in order to avoid the same problem with the registry.


        Make copyright string empty


        Fix signing server error

We already use the Digicert timestamp server in brave builds but need to also update it here as that might not pass down.


        Spacing mini-fix


        Update hammer-brave.bat


        Add missing headers


        Add libzip and zlib

* libzip 1.5.2 from https://libzip.org/download/libzip-1.5.2.tar.xz Unzip the contents of libzip-1.5.2.tar.gz\libzip-1.5.2.tar\libzip-1.5.2\ into the directory third_party\libzip * zlib 1.2.11 from https://zlib.net/zlib-1.2.11.tar.gz Unzip the contents of zlib-1.2.11.tar.gz\zlib-1.2.11.tar\zlib-1.2.11\ into the directory third_party\zlib\v1_2_11

emerick · 2019-07-18T14:27:54Z

Looks like there are a lot of conflicts, but I take it those won't be relevant if we're just going to make this the new master?

cc: @mbacchi and @mihaiplesa, just FYI - but assuming you already know this is coming...

mbacchi · 2019-07-18T16:29:06Z

I was not aware of this effort. I wonder if we need to coordinate this with the omaha-server rebase as we're behind there too, and have an open issue to rebase but no plan to do it in the near term: brave/devops#1092

simonhong · 2019-07-18T21:42:38Z

@mbacchi ~~I think this rebase doesn't need omaha-server rebase.~~
Rebased omaha updater doesn't work with current server. brave/brave-browser#5186 (comment)

simonhong · 2019-07-18T22:08:20Z

Looks like there are a lot of conflicts, but I take it those won't be relevant if we're just going to make this the new master?

Yes, it will not have any problem if this becomes master.

emerick · 2019-07-23T06:30:17Z

Rebased omaha updater doesn't work with current server. brave/brave-browser#5186 (comment)

How does that impact this PR? It seems like we would want to update either both (client and server) or neither, I think.

simonhong · 2019-07-23T06:51:25Z

@emerick yes, both side should be updated. So, this PR should be pended till we can start to debug together on updater client and server.
One more important thing is omaha server that we forked is not maintained by google.
So, latest omaha server impls could not work with latest google's omaha update client.
We have to deal with it also.

patmanpm and others added 30 commits Feb 7, 2018

Update DeveloperSetupGuide.md

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

6b6e79f

Corrected registry path for UpdateDev for 32-bit process usage

Fixed Spelling.

62d5459

Fixed Spelling.

a924f48

Trivial tyop fix.

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

b05f7b4

Merge pull request #139 from da4089/patch-1

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

4e135f6

Trivial tyop fix.

fingerprint→fp in SeverProtocolDocV3

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

349504f

Integrate from Omaha mainline up to 226393814.

441e209

Update CHANGELOG.txt

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

64b8b8b

Update DeveloperSetupGuide.md

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

5f5207f

Merge pull request #137 from jimmycasey/master

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

0a5f6c6

Fixed Spelling.

Merge pull request #129 from patmanpm/patch-1

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

bfcd89a

Update DeveloperSetupGuide.md

Update README.md

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

3709c70

Fixed markup.

Merge pull request #141 from hologramas/patch-1

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

4619c08

DeveloperSetupGuide.md protobuf version required.

Added missing ApplyTag.exe

7b2b1ef

Merge pull request #145 from macqm/master

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

b9874f7

Define NTDDI_VERSION correctly

Merge pull request #1 from google/master

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

2a60846

Merge pull request #145 from macqm/master

Update DeveloperSetupGuide required tools

e4cf932

Set WINVER and _WIN32_WINNT to _WIN32_WINNT_WIN7

c05961a

Update docs to instruct to use python 2.7

82beaaa

Merge pull request #147 from macqm/use_python_27

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

a3c2996

Use python 27

Merge pull request #146 from macqm/fix_winver

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

ede44c3

Update WINVER to Windows 7 value.

commit at CL 239258006

03e83a6

Merge branch 'master' of https://github.com/google/omaha

9c9d7bd

Update CHANGELOG.txt

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

0cca9ea

Update DeveloperSetupGuide.md

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

a72a8e4

Added libzip 1.3.0 and zlib 1.2.11 to third-party dependencies.

Merge pull request #149 from GitHubGanesh/patch-2

Verified

This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits

89da7d0

Update DeveloperSetupGuide.md

RyanJarv and others added 20 commits Jul 12, 2018

Update cup key for unofficial release

765b9ca

Store original path to registry to deliver promocode to installer

57d2c97

Update help url

3aead25

Set support.brave.com as a help url.

Updated with customizations and signing-related changes

7c7593a

Integrate omaha to brave_core

921d2e0

* Remove invalid third_party index and add .gitmodules * Create omaha target * Build stub/standalone installer with tagging

Make omaha build w/o admin priv

98b5d2d

It turns out that enterprise module only needs admin priv. Brave doesn't used it. So it is excluded from build dir list.

Pass cert and password parameters to hammer-brave.bat

63e1616

Fixes brave/brave-browser#1990

Use default 'prefers' for needsadmin tag in standalone installer.

bb54cbb

Remove unused CLI arg

8212534

Make release build only as a default

f32d3a4

Build all(release/debug) can take a long build time.

Create silent/untagged stub and standalone installers

07cd9df

This is part of the work for issue: brave/brave-browser#2210

Introduce silent tag for silent installer

495ba66

When silent tag is added in tag list, "/silent /install" is added to command line by metainstaller. silent tag should be added at last of tag list.

Send stats ping during startup, download, and installation

42dfe9d

Make copyright string empty

e334519

Fix signing server error

9ab252f

We already use the Digicert timestamp server in brave builds but need to also update it here as that might not pass down.

Spacing mini-fix

f3ddd7f

Update hammer-brave.bat

64d8c08

Add missing headers

4f73c60

simonhong self-assigned this Jul 18, 2019

simonhong requested review from bsclifton and emerick Jul 18, 2019

simonhong mentioned this pull request Jul 22, 2019

Rebase omaha #5186

Open

brave / omaha

WIP: Rebase omaha #25

WIP: Rebase omaha #25

simonhong commented Jul 18, 2019 •

edited

emerick commented Jul 18, 2019

mbacchi commented Jul 18, 2019

simonhong commented Jul 18, 2019 •

edited

simonhong commented Jul 18, 2019

emerick commented Jul 23, 2019

simonhong commented Jul 23, 2019 •

edited

brave / omaha

Join GitHub today

WIP: Rebase omaha #25

WIP: Rebase omaha #25

Conversation

simonhong commented Jul 18, 2019 • edited

emerick commented Jul 18, 2019

mbacchi commented Jul 18, 2019

simonhong commented Jul 18, 2019 • edited

simonhong commented Jul 18, 2019

emerick commented Jul 23, 2019

simonhong commented Jul 23, 2019 • edited

simonhong commented Jul 18, 2019 •

edited

simonhong commented Jul 18, 2019 •

edited

simonhong commented Jul 23, 2019 •

edited