Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Rebase omaha #25

Open
wants to merge 170 commits into
base: master
from
Open

WIP: Rebase omaha #25

wants to merge 170 commits into from
Commits on Feb 7, 2018
  1. Update DeveloperSetupGuide.md

    patmanpm committed Feb 7, 2018
    Corrected registry path for UpdateDev for 32-bit process usage
Commits on Jul 26, 2018
  1. Fixed Spelling.

    jimmycasey committed Jul 26, 2018
Commits on Jul 29, 2018
  1. Fixed Spelling.

    jimmycasey committed Jul 29, 2018
Commits on Oct 4, 2018
  1. Trivial tyop fix.

    da4089 committed Oct 4, 2018
Commits on Oct 10, 2018
  1. Merge pull request #139 from da4089/patch-1

    sorinj committed Oct 10, 2018
    Trivial tyop fix.
Commits on Dec 5, 2018
Commits on Dec 21, 2018
  1. Update CHANGELOG.txt

    sorinj committed Dec 21, 2018
  2. Update DeveloperSetupGuide.md

    sorinj committed Dec 21, 2018
Commits on Jan 8, 2019
  1. Merge pull request #137 from jimmycasey/master

    sorinj committed Jan 8, 2019
    Fixed Spelling.
  2. Merge pull request #129 from patmanpm/patch-1

    sorinj committed Jan 8, 2019
    Update DeveloperSetupGuide.md
  3. Update README.md

    sorinj committed Jan 8, 2019
    Fixed markup.
Commits on Jan 11, 2019
  1. DeveloperSetupGuide.md protobuf version required.

    hologramas committed Jan 11, 2019
    A dependency on 'protobuf/implicit_weak_message.cc' was added on PR 441e209. This file only exists on protobuf version 3.6.0 and higher and user older versions (which used to work before) now causes a build break.
    This pull request updates the guide to specify the new requirement.
  2. Merge pull request #141 from hologramas/patch-1

    sorinj committed Jan 11, 2019
    DeveloperSetupGuide.md protobuf version required.
Commits on Feb 14, 2019
  1. Added missing ApplyTag.exe

    sorinj committed Feb 14, 2019
Commits on Mar 4, 2019
  1. Define NTDDI_VERSION correctly

    macqm committed Mar 4, 2019
    `NTDDI_VERSION` was defined in CPPDEFINES as `DNTDDI_VERSION`. The D prefix would be valid for CPPFLAGS, but not here.
Commits on Mar 5, 2019
  1. Set WIN_VER and _WIN32_WINNT to 0x0502

    macqm committed Mar 5, 2019
    Set WIN_VER to _WIN32_WINNT_WS03 (0x0502)
    Add missing _WIN32_WINNT define.
    This targets "Windows XP with Service Pack 2 (SP2)".
Commits on Mar 7, 2019
  1. Merge pull request #145 from macqm/master

    sorinj committed Mar 7, 2019
    Define NTDDI_VERSION correctly
Commits on Mar 9, 2019
  1. Merge pull request #1 from google/master

    macqm committed Mar 9, 2019
    Merge pull request #145 from macqm/master
Commits on Mar 11, 2019
Commits on Mar 15, 2019
  1. Merge pull request #147 from macqm/use_python_27

    sorinj committed Mar 15, 2019
    Use python 27
  2. Merge pull request #146 from macqm/fix_winver

    sorinj committed Mar 15, 2019
    Update WINVER to Windows 7 value.
Commits on Mar 19, 2019
  1. commit at CL 239258006

    sorinj committed Mar 19, 2019
  2. Update CHANGELOG.txt CL 239101811 (Omaha 1.3.34.7)

    sorinj committed Mar 19, 2019
    Notable changes here include adding support for unpacking CRX files, making "Code Red" more secure by wrapping the payload in a CRX container, and fixing a race condition where the /ua process may hang on shutdown during a program update.
  3. Update CHANGELOG.txt

    sorinj committed Mar 19, 2019
  4. Update DeveloperSetupGuide.md

    GitHubGanesh committed Mar 19, 2019
    Added libzip 1.3.0 and zlib 1.2.11 to third-party dependencies.
Commits on Mar 20, 2019
  1. Merge pull request #149 from GitHubGanesh/patch-2

    sorinj committed Mar 20, 2019
    Update DeveloperSetupGuide.md
  2. fix long lines

    sorinj committed Mar 20, 2019
  3. fix trailing spaces

    sorinj committed Mar 20, 2019
Commits on Apr 9, 2019
  1. Remove unreferences headers

    macqm committed Apr 9, 2019
Commits on Apr 10, 2019
  1. Revert "Fixing build break caused by new dependency on libzip"

    hologramas committed Apr 10, 2019
    This reverts commit e657a04.
    
    Discussed with Google, they will update the instructions
  2. ICU_DECODE causes the URL parts to be unescaped. For our case, this c…

    hologramas committed Apr 10, 2019
    …an be catastrophic if the url contains a + character and the server
    
    is hosted on an IIS web server. IIS (and certain azure function hosts) do not route well resources that have the "+" character unless duble-escaping
    is enabling on the server which is not a default setting.
    When this happens, the server might return a 404 or a 403 depending on the unescaped resource and the routing configuration of the server.
    
    This change removed the ICU_DECODE flag from the simple_request implementation.
    We verified with our WinHTTP experts there is no good reason to be doing ICU_DECODE before sending out a request through winHTTP or winINET.
    The only case in which it might make sense if the server does not expect escaped URLs
    (which would be a failure to implement the standard) or if the Url is being craked for parsing but not for sending.
Commits on Apr 11, 2019
  1. Fix missing zipconf.h

    sorinj committed Apr 11, 2019
  2. Merge pull request #157 from hologramas/omaha/httpdecode

    sorinj committed Apr 11, 2019
    Omaha/httpdecode
  3. Merge pull request #156 from macqm/remove_unused_headers

    sorinj committed Apr 11, 2019
    Cleanup unreferenced headers
Commits on Apr 12, 2019
  1. Fix markup

    sorinj committed Apr 12, 2019
Commits on Apr 13, 2019
  1. Remove unused disk related methods from disk.h and system.h

    macqm committed Apr 13, 2019
    Moved class defined in dish. to system.h
  2. Remove unused code from shell.h

    macqm committed Apr 13, 2019
  3. Remove unused constants

    macqm committed Apr 13, 2019
  4. Remove IsGoogleUpdate2OrLater

    macqm committed Apr 13, 2019
  5. Cleanup vistautil.h

    macqm committed Apr 13, 2019
  6. Clean up vista_utils

    macqm committed Apr 13, 2019
  7. Clean up thread.h

    macqm committed Apr 13, 2019
  8. Clean up time.h

    macqm committed Apr 13, 2019
  9. Remove unused TimerScope

    macqm committed Apr 13, 2019
  10. Clean up system.h

    macqm committed Apr 13, 2019
Commits on Apr 15, 2019
  1. Merged PR 3125329: Remove stray submodule references

    lashtear committed Apr 10, 2019
    Remove stray submodule references
    
    This removes the breakpad and googletest submodule data, added by Sorin in Nov 2016.
    
    We're using gclient now, and the git config is already set for submodule ignore.
  2. Merge pull request #160 from lashtear/user/embackes/fix-stray-submodules

    sorinj committed Apr 15, 2019
    Remove stray submodule references
Commits on Apr 16, 2019
Commits on Apr 17, 2019
  1. Merge pull request #162 from macqm/fix_leak_response_handler

    sorinj committed Apr 17, 2019
    Fix a leaked pointer in XmlParser::VisitElement
Commits on Apr 18, 2019
  1. Fix gitignore

    sorinj committed Apr 18, 2019
  2. Merge pull request #163 from sorinj/gitignore

    sorinj committed Apr 18, 2019
    Fix gitignore
  3. Support VS2019 builds

    lashtear committed Apr 3, 2019
    Do not merge!
    
    This may require additional work to sort through necessary prior
    commits, like the Scons3 work.
    
    The included new python files in
    
        omaha/site_scons/site_tools/*_vc16_*.py
    
    are almost entirely derivative of prior versions of those files,
    so the copyrights are copied unchanged.
    
    Additional breakpad fixes are necessary, but might be resolved
    with more warnings disabled.
  4. Merge pull request #158 from macqm/dead_code_cleanup

    sorinj committed Apr 18, 2019
    Unused code cleanup
Commits on Apr 23, 2019
  1. Merge pull request #161 from lashtear/user/embackes/vs2019-on-github

    sorinj committed Apr 23, 2019
    Support VS2019 builds
  2. Fix .gitignore one more time.

    sorinj committed Apr 23, 2019
Commits on Apr 28, 2019
Commits on May 2, 2019
  1. Merge pull request #164 from macqm/remove_evil_ctor_macro

    sorinj committed May 2, 2019
    Remove DISALLOW_EVIL_CONSTRUCTORS macro
Commits on May 3, 2019
  1. Ignore .vscode folder

    macqm authored and sorinj committed May 3, 2019
  2. Remove references to the BHO

    macqm authored and sorinj committed May 3, 2019
Commits on May 9, 2019
  1. This is a bunch of changes including:

    sorinj committed May 8, 2019
    * Turning on x64 toolchain host support
    * Support for Visual Studio 2017 (15.9) including C++ compliance changes.
    * Eliminating MFC headers
    * Turning on /GS stack checks in all binary targets"
  2. Add support for VS2019.

    sorinj committed May 9, 2019
Commits on May 10, 2019
  1. Update DeveloperSetupGuide.md

    sorinj committed May 10, 2019
    VS2019 64-bit host toolchain  is the preferred now.
  2. fix typos

    sorinj committed May 10, 2019
Commits on May 16, 2019
  1. Allow C++17 language features.

    sorinj committed May 16, 2019
Commits on May 17, 2019
Commits on May 22, 2019
  1. Update DeveloperSetupGuide.md

    sorinj committed May 22, 2019
Commits on May 28, 2019
  1. Update DeveloperSetupGuide.md

    sorinj committed May 28, 2019
Commits on May 31, 2019
Commits on Jun 3, 2019
  1. Scoped_ptr to unique_ptr

    macqm authored and sorinj committed May 30, 2019
  2. Remove scoped_array

    macqm authored and sorinj committed May 30, 2019
  3. scoped_ptr_malloc to use unique_ptr

    macqm authored and sorinj committed May 31, 2019
  4. Use STL's shared_ptr

    macqm authored and sorinj committed May 31, 2019
  5. Delete scoped_ptr.h

    macqm authored and sorinj committed May 31, 2019
  6. Use make_unique

    macqm authored and sorinj committed May 31, 2019
Commits on Jun 5, 2019
  1. Update DeveloperSetupGuide.md

    sorinj committed Jun 5, 2019
Commits on Jun 13, 2019
  1. Add .clang-format file to the root.

    macqm authored and sorinj committed Jun 12, 2019
Commits on Jun 14, 2019
  1. Update DeveloperSetupGuide.md

    sorinj committed Jun 14, 2019
Commits on Jun 21, 2019
  1. Fix to pass buffer size.

    sudoudaisuke authored and sorinj committed Jun 21, 2019
Commits on Jun 25, 2019
  1. Fix a race in the Scheduler dtor after unique_ptr change (#180)

    macqm authored and sorinj committed Jun 25, 2019
    * Refactor Scheduler to decouple from Core and avoid races
    
    * Make SchedulerItem private class, clean headers
    
    * Fix GetDebugTimer
    
    * Clean up the unit test
    
    * Extract method for initializing scheduler, formatting
    
    * Hide boolean parameters, clean up the Scheduler interface
    
    * Style + formatting
    
    * Dont's at the and of the comments, remove redundant comment
Commits on Jun 28, 2019
  1. Remove extra quotation mark from .clang-format (#186)

    macqm authored and sorinj committed Jun 28, 2019
    Thank you!
  2. minor whitespace changes

    sorinj committed Jun 28, 2019
Commits on Jul 11, 2019
  1. Remove unused /netdiags mode

    macqm authored and sorinj committed Jul 11, 2019
  2. Remove unused QuotedPrintableUnescape

    macqm authored and sorinj committed Jul 11, 2019
  3. Remove unused String_PathFindExtension

    macqm authored and sorinj committed Jul 11, 2019
  4. Replace SafeStrCat with wcscat_s

    macqm authored and sorinj committed Jul 11, 2019
  5. Remove unused string helpers

    macqm authored and sorinj committed Jul 11, 2019
  6. Remove unused JoinStrings* helpers

    macqm authored and sorinj committed Jul 11, 2019
  7. Remove more unused string helpers

    macqm authored and sorinj committed Jul 11, 2019
Commits on Jul 12, 2019
  1. Signature verification infrastructure in preparation for full signatu…

    sorinj committed Jul 12, 2019
    …re verification of policy responses.
    
    * Plus, added signature verification of the new public key with the hardcoded verification key.
  2. Omaha moved to Python 2.7, so a standalone hashlib implementation is …

    sorinj committed Jul 12, 2019
    …not needed anymore. Originally, Python 2.4 did not have a hashlib implementation, resulting in a build break.
  3. Implement signature verification of the policy data with the new publ…

    sorinj committed Jul 12, 2019
    …ic key received from the server.
  4. Rolling back setup_google_update.cc to the old code before the <set> …

    sorinj committed Jul 12, 2019
    …change just to be safe. For instance, one gotcha with the new code with the <set> is that it is not doing a case insensitive comparison, whereas the old code was.
  5. Move to using enterprise_management::PublicKeyVerificationData instea…

    sorinj committed Jul 12, 2019
    …d of the deprecated enterprise_management::DEPRECATEDPolicyPublicKeyAndDomain.
  6. Switch to validating, using and storing PublicKeyVerificationData for…

    sorinj committed Jul 12, 2019
    … the public policy key, instead of the legacy data within PolicyFetchResponse and PolicyData.
Commits on Jul 15, 2019
  1. Update CHANGELOG.txt

    sorinj committed Jul 15, 2019
Commits on Jul 18, 2019
  1. Replace Google with Brave in string value from *.rc files

    simonhong committed May 20, 2018
    Replaced *.rc files in below dirs.
    * goopdate/resources/goopdate_dll/*.rc
    * goopdate/resources/goopdateres/*.rc
    * mi_exe_stub/*.rc
  2. Replace uuids

    simonhong committed May 20, 2018
    Replace uuides in below files.
    * base/const_object_names.h
    * goopdate/omaha3_idl.idl
    * plugins/update/activex/update_control_idl.idl
  3. Replace Omaha/OmahaCompanyName to Brave of constant values

    simonhong committed May 20, 2018
    Constants in below files are changed.
    * base/const_object_names.h
    * common/const_goopdate.h
    * recovery/repare_exe/msp/patchableinstaller.wxs
    * test/test_foo.wxs.xml
  4. Change update client appid

    simonhong committed May 20, 2018
    Use "B131C935-9BE6-41DA-9599-1F776BEB8019" instead of using
    "430FD4D0-B729-4F61-AA34-91526481799D".
    TODO: Update client id in chromium src.
  5. Change company name to BraveSoftware

    simonhong committed May 24, 2018
    Use BraveSoftware instead of Brave to avoid conflicing with muon
    based brave browser.
  6. Setting CUP

    simonhong committed Jun 8, 2018
  7. Use test server

    simonhong committed Jun 8, 2018
  8. Set new updater url

    RyanJarv authored and simonhong committed Jul 11, 2018
  9. Update cup key for unofficial release

    RyanJarv authored and simonhong committed Jul 12, 2018
  10. Update help url

    simonhong committed Oct 16, 2018
    Set support.brave.com as a help url.
  11. Integrate omaha to brave_core

    simonhong committed Oct 23, 2018
    * Remove invalid third_party index and add .gitmodules
    * Create omaha target
    * Build stub/standalone installer with tagging
  12. Make omaha build w/o admin priv

    simonhong committed Nov 5, 2018
    It turns out that enterprise module only needs admin priv.
    Brave doesn't used it. So it is excluded from build dir list.
  13. Remove unused CLI arg

    mbacchi authored and simonhong committed Nov 5, 2018
  14. Make release build only as a default

    simonhong committed Nov 7, 2018
    Build all(release/debug) can take a long build time.
  15. Create silent/untagged stub and standalone installers

    mbacchi authored and simonhong committed Nov 27, 2018
    This is part of the work for issue: brave/brave-browser#2210
  16. Introduce silent tag for silent installer

    simonhong committed Dec 5, 2018
    When silent tag is added in tag list, "/silent /install" is added to
    command line by metainstaller.
    silent tag should be added at last of tag list.
  17. Fix stats ping

    emerick authored and simonhong committed Jan 12, 2019
    The download-complete/installer-run stats pings weren't being sent
    when the stub installer was run in admin mode. This was due to us
    storing the app guid in the registry, as it is written to a different
    location when running as an admin vs a regular user. Fixed this by
    fetching app guid from tag instead. In addition, we append the
    referral code to the tag sent to the installer in order to avoid the
    same problem with the registry.
  18. Fix signing server error

    mbacchi authored and simonhong committed Jul 11, 2019
    We already use the Digicert timestamp server in brave builds
    but need to also update it here as that might not pass down.
  19. Spacing mini-fix

    mbacchi authored and simonhong committed Jul 11, 2019
  20. Update hammer-brave.bat

    simonhong committed Jul 18, 2019
  21. Add missing headers

    simonhong committed Jul 18, 2019
  22. Add libzip and zlib

    simonhong committed Jul 18, 2019
    * libzip 1.5.2 from https://libzip.org/download/libzip-1.5.2.tar.xz
    Unzip the contents of libzip-1.5.2.tar.gz\libzip-1.5.2.tar\libzip-1.5.2\
    into the directory third_party\libzip
    
    * zlib 1.2.11 from https://zlib.net/zlib-1.2.11.tar.gz
    Unzip the contents of zlib-1.2.11.tar.gz\zlib-1.2.11.tar\zlib-1.2.11\ into
    the directory third_party\zlib\v1_2_11
You can’t perform that action at this time.