Skip to content

/ omaha

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set specific SDK version for omaha build #26

Merged
merged 1 commit into from Jul 25, 2019
+1 −1
Merged

Set specific SDK version for omaha build #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
6b9eaf9
Set specific SDK version for omaha build
simonhong Jul 25, 2019
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Set specific SDK version for omaha build 

Just calling vcvarsall.bat w/o any args, it uses latest sdk version
on current windows when it sets env vars like WindowsSDKVer.
It fetches latest installed version from registry.
If we installed 10.0.18362, we can see WindowsSDKVer is set in
hammer-brave.bat by echo.
So far, it was ok but omaha build is failed with 10.0.18362.
Since C77, 18362 became as required SDK version. So, omaha build will
fail w/o this commit.
10.0.10586 is sdk requirement for our forked omaha version.
  • Loading branch information
@simonhong
simonhong committed Jul 25, 2019
commit 6b9eaf9b07452cee1b10b6b98f583dba95ddc72e
2 omaha/hammer-brave.bat
View file
Open in desktop
@@ -5,7 +5,7 @@
set OMAHA_PSEXEC_DIR=%ProgramFiles(x86)%\pstools

:: Set VS environment variables.
call "%VS140COMNTOOLS%..\..\VC\vcvarsall.bat"
call "%VS140COMNTOOLS%..\..\VC\vcvarsall.bat" x86 10.0.10586.0

setlocal

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.