Skip to content

/ qa-resources

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manual test plan #10

Merged
merged 4 commits into from Oct 31, 2017
Merged

Update manual test plan #10

merged 4 commits into from Oct 31, 2017

Conversation

@luixxiul
Copy link
Contributor

luixxiul commented Oct 7, 2017

  • Add .editorconfig (same as used on brave/browser-laptop)

Closes #2
Closes #3
Closes #4
Closes #9
@luixxiul luixxiul added the enhancement label Oct 7, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 10, 2017

CC @brave/qa
@srirambv
srirambv reviewed Oct 10, 2017
View changes
Copy link
Contributor

srirambv left a comment

Not sure if this test is required https://extensions.inrialpes.fr/brave/ . Site shows as Chrome irrespective of Shields settings and plugin enabled/disabled
@srirambv
srirambv reviewed Oct 10, 2017
View changes
wikitemplate.md Outdated

## Flash tests

1. [ ] Turn on Flash in about:preferences#security. Test that clicking on 'Install Flash' banner on myspace.com shows a notification to allow Flash and that the banner disappears when 'Allow' is clicked.

This comment has been minimized.

Sign in to view
Copy link
@srirambv

srirambv Oct 10, 2017

Contributor

This is also obselete. It now shows Cookie banner on the site. Can this be removed?

This comment has been minimized.

Sign in to view
Copy link
@luixxiul

luixxiul Oct 10, 2017

Author Contributor

Let's open an issue for that :-)
@srirambv
srirambv requested changes Oct 10, 2017
View changes
Copy link
Contributor

srirambv left a comment

Based on brave/browser-laptop#11327 (comment), URL needs to be changed to https
@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 10, 2017 •
edited

why wouldn't we address that with another PR for #13?
@luixxiul luixxiul mentioned this pull request Oct 10, 2017
Closed
@luixxiul luixxiul requested a review from srirambv Oct 10, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 10, 2017

Not sure if this test is required https://extensions.inrialpes.fr/brave/ . Site shows as Chrome irrespective of Shields settings and plugin enabled/disabled

This site had once detected Brave, so it should be kept I think.
@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 31, 2017

Rebased.
Suguru Hirahara and others added 4 commits Oct 5, 2017
Suguru Hirahara
Update wiki templates etc.
Unverified
No user is associated with the committer email.
Learn about signing commits
f87f9a4 
- Add .editorconfig (same as used on brave/browser-laptop)

Closes #2
Closes #3
Closes #4

Test Plan:
@srirambv Suguru Hirahara
Replace safebrowing URL
Unverified
No user is associated with the committer email.
Learn about signing commits
1dd1e40 
Closes #9
Suguru Hirahara
Add file extensions on generator scripts
Unverified
No user is associated with the committer email.
Learn about signing commits
f0d2ba5
Suguru Hirahara
Trim trailing whitespace on markdown files
Unverified
No user is associated with the committer email.
Learn about signing commits
b8a2d09
@luixxiul luixxiul removed the request for review from aekeus Oct 31, 2017
@luixxiul luixxiul merged commit 923623b into brave:master Oct 31, 2017
@luixxiul luixxiul removed the request for review from kjozwiak Oct 31, 2017
@luixxiul luixxiul deleted the luixxiul:update-manual-test-plan branch Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srirambv srirambv

Assignees

@luixxiul luixxiul

Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@luixxiul @srirambv @aekeus @alexwykoff @kjozwiak @LaurenWags
You can’t perform that action at this time.