Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tab test and update assignee #103

Merged
merged 1 commit into from Jan 29, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -33,6 +33,7 @@
iOS11_iPhone7_checklist = []
android_x86_checklist = []
android_arm_checklist = []
android_tab_checklist = []

laptop_milestone = {}
for laptopmilestone in laptop_repo.get_milestones(state="open"):
@@ -357,6 +358,9 @@ def android_testruns():
if('checked by qa - android x86' not in label_names and 'checked by qa' not in label_names):
android_x86_checklist.append(output_line)

if('checked by qa - Android Tab' not in label_names and 'checked by qa' not in label_names):
android_tab_checklist.append(output_line)

print("Release Notes:")
for line in release_notes:
print(line)
@@ -378,7 +382,7 @@ def android_testruns():
AndroidARMlist = ['ARM', 'release-notes/exclude', 'tests']

if args.test is None:
android_repo.create_issue(title=AndroidARMtitle,body=bigline,assignee="LaurenWags",milestone=android_milestone[android_key] ,labels=AndroidARMlist)
android_repo.create_issue(title=AndroidARMtitle,body=bigline,assignee="GeetaSarvadnya",milestone=android_milestone[android_key] ,labels=AndroidARMlist)

print("Android x86 Checklist:")
bigline = "## Per release specialty tests\n"
@@ -391,7 +395,20 @@ def android_testruns():
Androidx86list = ['x86', 'release-notes/exclude', 'tests']

if args.test is None:
android_repo.create_issue(title=Androidx86title,body=bigline,assignee="srirambv",milestone=android_milestone[android_key] ,labels=Androidx86list)
android_repo.create_issue(title=Androidx86title,body=bigline,assignee="LaurenWags",milestone=android_milestone[android_key] ,labels=Androidx86list)

print("Android Tab Checklist:")
bigline = "## Per release specialty tests\n"
for line in android_tab_checklist:
bigline += line + "\n"
bigline = bigline + android_template
print(bigline)
print("")
AndroidTabtitle = "Manual test run on Android Tab for " + android_key
AndroidTablist = ['ARM', 'release-notes/exclude', 'tests']
This conversation was marked as resolved by srirambv

This comment has been minimized.

Copy link
@LaurenWags

LaurenWags Jan 29, 2019

Contributor

Looks like you're adding labels to the Tablet test run for ARM, release-notes/exclude and tests. Do we want the ARM label to be something like 'Tablet' instead? ARM is probably fine since I'm guessing the tablet is an ARM device, just wondering.

This comment has been minimized.

Copy link
@srirambv

srirambv Jan 29, 2019

Author Contributor

Well I was just going by the device architecture similar to mobile but I can update it to ARM/Tab to be more specific. WDYT?

This comment has been minimized.

Copy link
@LaurenWags

LaurenWags Jan 29, 2019

Contributor

Device architecture sgtm. We can always update later if it becomes a problem.


if args.test is None:
android_repo.create_issue(title=AndroidTabtitle,body=bigline,assignee="srirambv",milestone=android_milestone[android_key] ,labels=AndroidTablist)

return

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.