Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync tests for all platforms #113

Merged
merged 2 commits into from Apr 12, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev

Fix reviews and minor text changes

  • Loading branch information
srirambv committed Apr 9, 2019
commit 17cc15eed5957709d57ea006f635b8df4c5c6e30
@@ -14,6 +14,7 @@ Pre-Requisite: Put previous build shortcut on home screen. Also have several sit
- [ ] Verify that the cookies from the previous build are preserved in the updated build
- [ ] Verify shortcut is still available on home screen after updating Brave
- [ ] Verify sites added to home screen are still visible and able to be used after updating Brave
- [ ] Verify sync chain created in previous version is still retained on upgrade

## Bookmarks

@@ -35,6 +36,10 @@ Pre-Requisite: Put previous build shortcut on home screen. Also have several sit
- [ ] Make sure context menu items on content work with selected text
- [ ] Make sure context menu items on content work inside an editable control (input, textarea, or contenteditable)

## Developer Tools

- [ ] Verify you are able to inspect sublinks via dev tools

## Find in page

- [ ] Ensure search box is shown when selected via the hamburger menu
@@ -44,7 +49,7 @@ Pre-Requisite: Put previous build shortcut on home screen. Also have several sit

## Site hacks

- [ ] Test https://www.twitch.tv/adobe sub-page loads a video and you can play it
- [ ] Verify https://www.twitch.tv/adobe sub-page loads a video and you can play it

## Downloads

@@ -58,7 +63,7 @@ Pre-Requisite: Put previous build shortcut on home screen. Also have several sit

## Autofill tests

- [ ] Test that autofill works on http://www.roboform.com/filling-test-all-fields
- [ ] Test that autofill works on https://srirambv.github.io/formfiller.html

## Zoom

@@ -70,17 +75,16 @@ Pre-Requisite: Put previous build shortcut on home screen. Also have several sit
- [ ] Verify you are able to join sync chain by scanning the QR code
- [ ] Verify you are able to join sync chain using code words
- [ ] Verify you are able to create a sycn chain on the device and add other devices to the chain via QR code/Code words
- [ ] Verify the bookmarks from other devices on the chain show up on the mobile after sync completes
- [ ] Verify new bookmarks added gets sync'd to all devices on the sync chain
- [ ] Verify that bookmarks from other devices on the chain show up on the mobile device after sync completes
- [ ] Verify newly created bookmarks gets sync'd to all devices on the sync chain
- [ ] Verify existing bookmarks before joining sync chain also gets sync'd to all devices on the sync chain
- [ ] Verify sync chain created in previous version is still retained on upgrade
- [ ] Verify sync works on a upgrade profile and new bookmarks added post upgrade sync's across devices on the chain
This conversation was marked as resolved by srirambv

This comment has been minimized.

Copy link
@kjozwiak

kjozwiak Mar 27, 2019

Member

Same as the above suggestion, maybe this will be better under the data section where we handle the upgrades?

- [ ] Verify add a bookmark on custom tab gets sync'd across all devices in the chain
- [ ] Verify you are able to create a standalone sync chain with one device

## Bravery settings

- [ ] Check that HTTPS Everywhere works by loading https://https-everywhere.badssl.com/
- [ ] Check that HTTPS Everywhere works by loading http://https-everywhere.badssl.com/
- [ ] Turning HTTPS Everywhere off and shields off both disable the redirect to https://https-everywhere.badssl.com/
- [ ] Check that toggling to blocking and allow ads works as expected
- [ ] Test that clicking through a cert error in https://badssl.com/ works
@@ -9,8 +9,9 @@
- [ ] Make sure that data from the last version appears in the new version OK
- [ ] Test that the previous version's cookies are preserved in the next version
- [ ] Test that saved passwords are retained upon upgrade
- [ ] Ensure stats are retained when upgrading from previous version
- [ ] Ensure per site settings are retained when upgrading from previous version
- [ ] Verify stats are retained when upgrading from previous version
- [ ] Verify per site settings are retained when upgrading from previous version
- [ ] Verify sync chain created in previous version is still retained on upgrade

## Bookmarks

@@ -40,7 +41,7 @@

## Find on page

- [ ] Ensure search box is shown when selected via the share menu
- [ ] Verify search box is shown when selected via the share menu
- [ ] Test successful find
- [ ] Test forward and backward find navigation
- [ ] Test failed find shows 0 results
@@ -78,8 +79,8 @@

## Gestures

- [ ] Test zoom in / out gestures work
- [ ] Test that navigating to a different origin resets the zoom
- [ ] Verify zoom in / out gestures work on https://www.homedepot.com/
- [ ] Verify that navigating to a different origin resets the zoom
- [ ] Swipe back and forward to navigate, verify this works as expected

## Password Managers
@@ -97,14 +98,13 @@

## Sync

- [ ] Ensure you are able to join sync chain by scanning the QR code
- [ ] Ensure you are able to join sync chain using code words
- [ ] Ensure you are able to create a sycn chain on the device and add other devices to the chain via QR code/Code words
- [ ] Ensure the bookmarks from other devices on the chain show up on the mobile after sync completes
- [ ] Verify new bookmarks added gets sync'd to all devices on the sync chain
- [ ] Verify you are able to join sync chain by scanning the QR code
- [ ] Verify you are able to join sync chain using code words
- [ ] Verify you are able to create a sycn chain on the device and add other devices to the chain via QR code/Code words
- [ ] Verify that bookmarks from other devices on the chain show up on the mobile device after sync completes
- [ ] Verify newly created bookmarks get sync'd to all devices on the sync chain
- [ ] Verify existing bookmarks before joining sync chain also gets sync'd to all devices on the sync chain
- [ ] Ensure sync chain created in previous version is still retained on upgrade
- [ ] Ensure sync works on a upgrade profile and new bookmarks added post upgrade sync's across devices on the chain
- [ ] Verify sync works on a upgrade profile and new bookmarks added post upgrade sync's across devices on the chain
- [ ] Verify you are able to create a standalone sync chain with one device

## Bravery settings
@@ -141,7 +141,7 @@
## Background
- [ ] Start loading a page, background the app, wait >5 sec, then bring to front, ensure splash screen is not shown
- [ ] Start loading a page, background the app, wait >5 sec, then bring to front, Verify splash screen is not shown
## Session storage
@@ -14,6 +14,7 @@
- [ ] opened tabs can be reloaded
- [ ] stored passwords are preserved
- [ ] unpinned tabs can be pinned
- [ ] Sync chain created in previous version is retained

### About pages

@@ -150,7 +151,7 @@ _Each start should take less than 7 seconds_
- [ ] Verify you are able to join an existing sync chain using code words
- [ ] Verify the device name is shown properly when sync chain is created
- [ ] Verify you are able to add a new mobile device to the chain via QR code/code words
- [ ] Verify new bookmarks added gets sync'd to all devices on the sync chain
- [ ] Verify newly created bookmarks get sync'd to all devices on the sync chain
- [ ] Verify existing bookmarks on current profile gets sync'd to all devices on the sync chain
- [ ] Verify folder structure is retained after sync completes
- [ ] Verify bookmarks don't duplicate when sync'd from other devices
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.