Add rewards test #140
+72
−31
Fix review comments
- Loading branch information
| @@ -17,7 +17,7 @@ Pre-Requisite: Put previous build shortcut on the home screen. Also, have severa | ||
| - [ ] Verify shortcut is still available on the home screen after upgrade | ||
| - [ ] Verify sites added to home screen are still visible and able to be used after upgrade | ||
| - [ ] Verify sync chain created in the previous version is still retained on upgrade | ||
| - [ ] Verify settings changes done in the previous version is still retained on upgrade | ||
| - [ ] Verify settings changes done in the previous version are still retained on upgrade | ||
|
|
||
| ## Bookmarks | ||
|
|
||
| @@ -142,15 +142,15 @@ Pre-Requisite: Put previous build shortcut on the home screen. Also, have severa | ||
|
|
||
| ## Sync | ||
|
This conversation was marked as resolved
by srirambv
|
||
|
|
||
| - [ ] Verify you can join sync chain by scanning the QR code | ||
| - [ ] Verify you can join sync chain using code words | ||
| - [ ] Verify you can create a sync chain on the device and add other devices to the chain via QR code/Codewords | ||
| - [ ] Verify you are able to join sync chain by scanning the QR code | ||
| - [ ] Verify you are able to join sync chain using code words | ||
| - [ ] Verify you are able to create a sync chain on the device and add other devices to the chain via QR code/Code words | ||
| - [ ] Verify that bookmarks from other devices on the chain show up on the mobile device after sync completes | ||
| - [ ] Verify newly created bookmarks gets sync'd to all devices on the sync chain | ||
|
This conversation was marked as resolved
by srirambv
|
||
| - [ ] Verify existing bookmarks before joining sync chain also gets sync'd to all devices on the sync chain | ||
|
This conversation was marked as resolved
by srirambv
|
||
| - [ ] Verify sync works on an upgrade profile and new bookmarks added post-upgrade sync's across devices on the chain | ||
| - [ ] Verify add a bookmark on custom tab gets synced across all devices in the chain | ||
| - [ ] Verify you can create a standalone sync chain with one device | ||
| - [ ] Verify adding a bookmark on custom tab gets synced across all devices in the chain | ||
| - [ ] Verify you are able to create a standalone sync chain with one device | ||
|
|
||
| ## Top sites view | ||
|
|
||
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
general wording in Sync section - noticed you primarily used 'are able' instead of 'can' in iOS, consider changing here as well for consistency.