Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rewards/WebAuthn tests #155

Merged
merged 1 commit into from Jan 2, 2020
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Add Rewards/WebAuthn tests

  • Loading branch information
srirambv committed Dec 14, 2019
commit 2e85b0399c367bef3796a71922de46e8314aa8a7
@@ -6,30 +6,30 @@

## Data

- [ ] Make sure that data from the last version appears in the new version OK
- [ ] Test that the previous version's cookies are preserved in the next version
- [ ] Test that saved passwords are retained upon upgrade
- [ ] Verify stats are retained when upgrading from the previous version
- [ ] Verify per-site settings are retained when upgrading from the previous version
- [ ] Verify that data from the previous build appears in the updated build as expected (bookmarks, etc)
- [ ] Verify that the cookies from the previous build are preserved after upgrade
- [ ] Verify saved password are retained after upgrade
- [ ] Verify stats are retained after upgrade
- [ ] Verify sync chain created in the previous version is still retained on upgrade
- [ ] Verify per-site settings are preserved after upgrade

## Bookmarks

- [ ] Test that creating a bookmark works
- [ ] Test that clicking a bookmark from bookmark manager loads the bookmark
- [ ] Test that deleting a bookmark works
- [ ] Test that creating a bookmark folder works
- [ ] Test that creating a bookmark inside the created folder works
- [ ] Test that you can add a bookmark directly inside a bookmark folder
- [ ] Test that you can delete a bookmark in edit mode
- [ ] Test that you can delete a bookmark folder with bookmarks inside
- [ ] Test adding a bookmark domain, subpaths is retained and you are successfully able to visit the domain subpath in a new tab
- [ ] Verify that creating a bookmark works
- [ ] Verify that clicking a bookmark from bookmark manager loads the bookmark
- [ ] Verify that deleting a bookmark works
- [ ] Verify that creating a bookmark folder works
- [ ] Verify that creating a bookmark inside the created folder works
- [ ] Verify that you can add a bookmark directly inside a bookmark folder
- [ ] Verify that you can delete a bookmark in edit mode
- [ ] Verify that you can delete a bookmark folder with bookmarks inside
- [ ] Verify adding a bookmark domain, subpaths is retained and you are successfully able to visit the domain subpath in a new tab

## Favourites

- [ ] Test editing favourite and changing URL updates the favicons accordingly
- [ ] Test that you can remove favourites
- [ ] Test that you can add new favourites from the share menu
- [ ] Verify editing favourite and changing URL updates the favicons accordingly
- [ ] Verify that you can remove favourites
- [ ] Verify that you can add new favourites from the share menu

## Context menus

@@ -42,15 +42,18 @@
## Find on page

- [ ] Verify search box is shown when selected via the share menu
- [ ] Test successful find
- [ ] Test forward and backward find navigation
- [ ] Test failed to find shows 0 results
- [ ] Verify successful find
- [ ] Verify forward and backward find navigation
- [ ] Verify failed to find shows 0 results

## Private Mode

- [ ] Create private tab, go to http://google.com, search for 'yumyums', exit private mode, go to http://google.com search box and begin typing 'yumyums' and verify that word is not in the autocomplete list
- [ ] Verify enabling `Private Browsing Only` shows warn message about sessions being lost in normal mode
- [ ] Verify switching from `Private Browsing Only` to normal mode doesn't retain any sessions from before

## Reader Mode

- [ ] Visit http://theverge.com, open any article, verify the reader mode icon is shown in the URL bar
- [ ] Verify tapping on the reader mode icon opens the article in reader mode
- [ ] Edit reader mode settings and open different pages in reader mode and verify if the setting is retained across each article
@@ -66,16 +69,16 @@

## Site hacks

- [ ] Test https://www.twitch.tv/adobe sub-page loads a video and you can play it
- [ ] Verify https://www.twitch.tv/adobe sub-page loads a video and you can play it

## Downloads

- [ ] Test that you can save an image from a site
- [ ] Test that you are able to save a gif image
- [ ] Verify that you can save an image from a site
- [ ] Verify that you are able to save a gif image

## Fullscreen

- [ ] Test that entering HTML5 fullscreen works. And pressing restore to go back exits full screen. (youtube.com)
- [ ] Verify that entering HTML5 fullscreen works. And pressing restore to go back exits full screen. (youtube.com)

## Gestures

@@ -85,16 +88,54 @@

## Password Managers

- [ ] Test tapping on 1Password on the slide-out keyboard launches 1Password App and able to select the stored credentials
- [ ] Test tapping on bitwarden password manager in the autofill field launches the app and auto-fills the stored data
- [ ] Verify tapping on 1Password on the slide-out keyboard launches 1Password App and able to select the stored credentials
- [ ] Verify tapping on bitwarden password manager in the autofill field launches the app and auto-fills the stored data

## Browser Lock

- [ ] Test enabling browser pin settings asks for pin confirmation followed by reconfirm
- [ ] Test swipe up/swipe down with browser in focus doesn't ask for pin confirmation
- [ ] Test clicking on set pin asks for the pin to unlock before setting a new pin
- [ ] Verify enabling browser pin settings asks for pin confirmation followed by reconfirm
- [ ] Verify swipe up/swipe down with browser in focus doesn't ask for pin confirmation
- [ ] Verify clicking on set pin asks for the pin to unlock before setting a new pin
- [ ] Remove the app from memory and relaunch, enter a wrong pin, the browser should not be unlocked
- [ ] Test cancel fingerprint confirmation shows enter pin window when fingerprint unlock is set up on the device
- [ ] Verify cancel fingerprint confirmation shows enter pin window when fingerprint unlock is set up on the device

## Brave Rewards/Ads

- [ ] Verify wallet is auto-created after enabling rewards
- [ ] Verify account balance shows correct BAT and USD value
- [ ] Verify actions taken (claiming grant, tipping, auto-contribute) display in wallet panel
- [ ] Verify grant details are shown in detailed view when a grant is claimed
- [ ] Verify monthly budget shows correct BAT and USD value
- [ ] Verify you can exclude a publisher from the auto-contribute table via left swipe
- [ ] Verify you can exclude a publisher by using the toggle on the Rewards Panel
- [ ] Verify you can remove excluded sites via `Restore All` button
- [ ] Verify when you click on the BR panel while on a site, the panel displays site-specific information (site favicon, domain, attention %)
- [ ] Verify when you click on `Send a tip`, the custom tip banner displays
- [ ] Verify you can make a one-time tip and they display in tips panel
- [ ] Verify you can make a recurring tip and they display in tips panel
- [ ] Verify you can tip a verified publisher
- [ ] Verify you can tip a verified YouTube/Twitter/GitHub/Reddit creator
- [ ] Verify tip panel shows a verified checkmark for a verified publisher/verified YouTube/Twitter/GitHub/Reddit creator
- [ ] Verify tip panel shows a message about the unverified publisher
- [ ] Verify BR panel shows the message about an unverified publisher
- [ ] Verify you can perform a contribution
- [ ] Verify if you disable auto-contribute you are still able to tip regular sites and YouTube/Twitter/Github creators
- [ ] Verify that disabling Rewards and enabling it again does not lose state
- [ ] Verify that disabling auto-contribute and enabling it again does not lose state
- [ ] Verify disabling `Allow contribution to videos` option doesn't list any YouTube creator in ac list
- [ ] Adjust min page time/visit in settings. Visit some sites and YouTube channels to verify they are added to the table after the specified settings
- [ ] Verify you can `Hide Brave Rewards Icon` works and doesn't show rewards button when not enabled
- [ ] Upgrade from an older version
- [ ] Verify the wallet balance (if available) is retained
- [ ] Verify auto-contribute list is not lost after upgrade
- [ ] Verify tips list is not lost after upgrade
- [ ] Verify wallet panel transactions list is not lost after upgrade
### Brave Ads
- [ ] Verify ads is auto-enabled when rewards is enabled for the supported region
- [ ] Verify ads are only shown when the app is being used
- [ ] Verify ad notification are shown based on ads per hour setting
- [ ] Verify clicking on an ad notification shows the landing page
- [ ] Verify `view`,`clicked` and `landed` and `dismiss` states are logged based on the action

## Sync

@@ -113,27 +154,35 @@
- [ ] Turning HTTPS Everywhere off or shields off both disable the redirect to https://https-everywhere.badssl.com/
- [ ] Check that block ad and unblock ad works on http://slashdot.org
- [ ] Check that toggling to blocking and allow ads works as expected
- [ ] Test that clicking through a cert error in https://badssl.com/ works
- [ ] Test that Safe Browsing works (https://www.raisegame.com/)
- [ ] Verify that clicking through a cert error in https://badssl.com/ works
- [ ] Verify that Safe Browsing works (https://www.raisegame.com/)
- [ ] Turning Safe Browsing off and shields off both disable safe browsing for https://www.raisegame.com/
- [ ] Enable block script globally from settings, Visit https://brianbondy.com/, nothing should load. Tap on Shields and disable block script, the page should load properly
- [ ] Test that preferences default Bravery settings take effect on pages with no site settings
- [ ] Test that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/7/ when 3rd party cookies are blocked
- [ ] Verify that preferences default Bravery settings take effect on pages with no site settings
- [ ] Verify that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/7/ when 3rd party cookies are blocked
### Fingerprint Tests
- [ ] Test that turning on fingerprinting protection in preferences shows 1 fingerprint blocked at https://browserleaks.com/canvas . Test that turning it off in the Bravery menu shows 0 fingerprints blocked
- [ ] Test that audio fingerprint is blocked at https://audiofingerprint.openwpm.com/ when fingerprinting protection is on
- [ ] Test that https://diafygi.github.io/webrtc-ips/ doesn't leak IP address when `Block all fingerprinting protection` is on
- [ ] Verify that turning on fingerprinting protection in preferences shows 1 fingerprint blocked at https://browserleaks.com/canvas . Verify that turning it off in the Bravery menu shows 0 fingerprints blocked
- [ ] Verify that audio fingerprint is blocked at https://audiofingerprint.openwpm.com/ when fingerprinting protection is on
- [ ] Verify that https://diafygi.github.io/webrtc-ips/ doesn't leak IP address when `Block all fingerprinting protection` is on

## Content tests

- [ ] Go to https://brianbondy.com/ and click on the twitter icon on the top right. Test that context menus work in the new twitter tab
- [ ] Go to https://brianbondy.com/ and click on the twitter icon on the top right. Verify that context menus work in the new twitter tab
- [ ] Load twitter and click on a tweet so the popup div shows. Click to dismiss and repeat with another div. Make sure it shows
- [ ] Go to https://trac.torproject.org/projects/tor/login and make sure that the password can be saved. Make sure the saved password is auto-populated when you visit the site again
- [ ] Open an email on http://mail.google.com/ or inbox.google.com and click on a link. Make sure it works
- [ ] Test that PDF is loaded over https at https://basicattentiontoken.org/BasicAttentionTokenWhitePaper-4.pdf
- [ ] Test that PDF is loaded over HTTP at http://www.pdf995.com/samples/pdf.pdf
- [ ] Test that https://mixed-script.badssl.com/ shows up as grey not red (no mixed content scripts are run)
- [ ] Test that search results from https://startpage.com/ open in a new tab (due to target being _blank_)
- [ ] Verify that PDF is loaded over https at https://basicattentiontoken.org/BasicAttentionTokenWhitePaper-4.pdf
- [ ] Verify that PDF is loaded over HTTP at http://www.pdf995.com/samples/pdf.pdf
- [ ] Verify that https://mixed-script.badssl.com/ shows up as grey not red (no mixed content scripts are run)
- [ ] Verify that search results from https://startpage.com/ open in a new tab (due to target being _blank_)

## WebAuthn

- [ ] Verify browser prompts for security key when trying to login to accounts
- [ ] Verify you are able to successfully authenticate an account using security key when prompted
- [ ] Verify quickly connect and disconnect doesn't cause issue authenticating using security keys
- [ ] Verify you are able to use security keys on both normal and private tabs
- [ ] Verify you are able to use security keys to authenticate using NFC

## App linker

@@ -145,4 +194,4 @@

## Session storage

- [ ] Test that tabs restore when closed, including active tab
- [ ] Verify that tabs restore when closed, including active tab
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.