Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate BAT tests #17
Update BAT tests #17
Conversation
|
++ looks good to me, will wait for @kjozwiak to give input. |
|
Looks good other than a few nitpicks like extra lines... Pulled PR and tested, looks like everything was generated correctly.. Bugs are being included etc.. Also compared wikitemplate-cr-upgrade to the old Wiki and ensured we're not missing any cases etc.. |
|
|
||
| ## Update tests | ||
|
|
||
| - [ ] Test that updating using `BRAVE_UPDATE_VERSION=0.-3` env variable works correctly. |
This comment has been minimized.
This comment has been minimized.
kjozwiak
Oct 24, 2017
Member
nitpick: not 100% sure if BRAVE_UPDATE_VERSION will work correctly with a - character... We should revert this back to BRAVE_UPDATE_VERSION=0.8.3.... Unless of course, this was intended.
Example of the previous Update tests:
|
|
||
| args = parser.parse_args() | ||
|
|
||
|
|
This comment has been minimized.
This comment has been minimized.
| args = parser.parse_args() | ||
|
|
||
|
|
||
|
|
This comment has been minimized.
This comment has been minimized.
| - [ ] Only import a large set of bookmarks. | ||
| - [ ] Combine sync, payments, and a large set of bookmarks. | ||
|
|
||
| ## Ledger |
This comment has been minimized.
This comment has been minimized.
| - [ ] Check that disabling payments and enabling them again does not lose state. | ||
|
|
||
|
|
||
| ## Sync |
This comment has been minimized.
This comment has been minimized.
| - [ ] Test that clicking a bookmark in the toolbar loads the bookmark. | ||
| - [ ] Test that clicking a bookmark in a bookmark toolbar folder loads the bookmark. | ||
|
|
||
| ## Context menus |
This comment has been minimized.
This comment has been minimized.
| - [ ] Test that PDF is loaded at http://www.orimi.com/pdf-test.pdf | ||
| - [ ] Test that https://mixed-script.badssl.com/ shows up as grey not red (no mixed content scripts are run). | ||
|
|
||
| ## Flash tests |
This comment has been minimized.
This comment has been minimized.
| - [ ] Test that flash placeholder appears on http://www.homestarrunner.com | ||
| - [ ] Test with flash enabled in preferences, auto play option is shown when visiting http://www.homestarrunner.com | ||
|
|
||
| ## Autofill tests |
This comment has been minimized.
This comment has been minimized.
| - [ ] Change min visit and min time in advance setting and verify if the publisher list gets updated based on new setting | ||
| - [ ] Visit nytimes.com for a few seconds and make sure it shows up in the Payments table. | ||
| - [ ] Check that disabling payments and enabling them again does not lose state. | ||
|
|
This comment has been minimized.
This comment has been minimized.
|
@kjozwiak updated as per feedback |
|
@srirambv looks like the PR has some conflicts, mind rebasing? Let me know if you need any help with it. |
srirambv commentedOct 10, 2017
Closes #7