Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media ledger tests #31

Merged
merged 2 commits into from Nov 15, 2017
Merged

Add media ledger tests #31

merged 2 commits into from Nov 15, 2017

Conversation

@srirambv
Copy link
Contributor

srirambv commented Nov 15, 2017

Closes #30

@srirambv srirambv self-assigned this Nov 15, 2017
@srirambv srirambv requested review from kjozwiak and LaurenWags Nov 15, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Nov 15, 2017

@kjozwiak mind asking someone of the team to create random channels to test the edge cases?

Copy link
Member

kjozwiak left a comment

@srirambv can you add one more case that involves changing Advanced Settings and ensuring the entries are still being added into the ledger table? Other then that, everything looks good 👍

@kjozwiak
Copy link
Member

kjozwiak commented Nov 15, 2017

@kjozwiak mind asking someone of the team to create random channels to test the edge cases?

very long name (as we tested https://longextendedsubdomainnamewithoutdashesinordertotestwordwrapping.badssl.com/ for the bravery channel)
l10n (non-ASCII; french and CJK - important to test cases in languages which do not have whitespaces)

Great idea... I'll create a few channels with the above suggestions and add the credentials into 1Password.

@srirambv
Copy link
Contributor Author

srirambv commented Nov 15, 2017

@kjozwiak updated tests

@kjozwiak kjozwiak merged commit 68a94c4 into brave:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.