Replace pdf source link #36

srirambv · 2017-11-27T17:02:06Z

Closes #35


        Replace pdf source link

kjozwiak

@srirambv we should probably either keep the one that's already being listed or use another PDF that's using HTTP... This way we'll have both HTTP & HTTPS PDF's.... Thoughts?


        Add pdf http/https links

srirambv · 2017-11-27T17:47:26Z

Sounds good. Added pdf link for both http and https

kjozwiak

@srirambv we should probably also add this change into wikitemplate-android.md as well.


        Add pdf http/https to mobile tests

srirambv · 2017-11-27T18:12:31Z

Added test links for mobile test runs as well

kjozwiak

@srirambv looks like the new HTTP/HTTPS cases for PDF's hasn't been added into wikitemplate-ios.md


        Update iOS with pdf links

srirambv · 2017-11-28T16:24:01Z

Added the links for iOS too. Should be on all templates now

kjozwiak · 2017-11-28T21:04:32Z

wikitemplate-android.md

+- [ ] Open a github issue and type some misspellings, make sure they are underlined.
+- [ ] Make sure that right clicking on a word with suggestions gives a suggestion and that clicking on the suggestion replaces the text.
+- [ ] Open an email on http://mail.google.com/ or inbox.google.com and click on a link. Make sure it works.
+- [ ] Test that PDF is loaded over https at https://basicattentiontoken.org/BasicAttentionTokenWhitePaper--pdf


Should be https://basicattentiontoken.org/BasicAttentionTokenWhitePaper-4.pdf

kjozwiak · 2017-11-28T21:04:32Z

wikitemplate-ios.md

+- [ ] Load twitter and click on a tweet so the popup div shows.   Click to dismiss and repeat with another div. Make sure it shows
+- [ ] Go to https://trac.torproject.org/projects/tor/login and make sure that the password can be saved.  Make sure the saved password is auto-populated when you visit the site again.
+- [ ] Open an email on http://mail.google.com/ or inbox.google.com and click on a link. Make sure it works
+- [ ] Test that PDF is loaded over https at https://basicattentiontoken.org/BasicAttentionTokenWhitePaper--pdf


Should be https://basicattentiontoken.org/BasicAttentionTokenWhitePaper-4.pdf


        Added FP tests based on #12121 and fix pdf links

srirambv · 2017-11-29T08:04:28Z

Fixed pdf links and updated fingerprint tests for browser-laptop based on brave/browser-laptop#12121 (comment)

kjozwiak · 2017-12-05T22:06:22Z

wikitemplate.md

+
+**Fingerprinting Tests (Enable fingerprinting protection in `about:preferences#shields`)**
+- [ ] Visit https://jsfiddle.net/bkf50r8v/13/, ensure 3 blocked items are listed in shields. Result window should show `got canvas fingerprint 0`  and  `got webgl fingerprint 00`
+- [ ] Visit https://audiofingerprint.openwpm.com/, ensure 2 blocked items are listed in shields. Audio fingerprint graph is shown but doens't contain user fingerprint graph represented in blue line
 - [ ] Test that browser is not detected on https://extensions.inrialpes.fr/brave/


This should be moved above the Fingerprinting Tests as it's not related to FP... Test ensures that we're appearing as Chrome.

kjozwiak · 2017-12-05T22:06:22Z

wikitemplate-ios.md

+- [ ] Test that preferences default Bravery settings take effect on pages with no site settings.
+- [ ] Test that turning on fingerprinting protection in preferences shows 1 fingerprints blocked at https://browserleaks.com/canvas . Test that turning it off in the Bravery menu shows 0 fingerprints blocked.
+- [ ] Test that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/7/ when 3rd party cookies are blocked.
+- [ ] Test that audio fingerprint is blocked at https://audiofingerprint.openwpm.com/ when fingerprinting protection is on.



Should update the FP tests under iOS to match the formatting & structure of wikitemplate.md.

kjozwiak · 2017-12-05T22:06:22Z

wikitemplate-android.md

+- [ ] Test that about:preferences default Bravery settings take effect on pages with no site settings.
+- [ ] Not Yet Implemented - Test that turning on fingerprinting protection in about:preferences shows 3 fingerprints blocked at https://jsfiddle.net/bkf50r8v/13/. Test that turning it off in the Bravery menu shows 0 fingerprints blocked.
+- [ ] Test that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/7/ when 3rd party cookies are blocked.
+- [ ] Not Yet Implemented - Test that audio fingerprint is blocked at https://audiofingerprint.openwpm.com/ when fingerprinting protection is on.



Should update the FP tests under android to match the formatting & structure of wikitemplate.md.


        Fix mobile template to match laptop template

srirambv · 2017-12-06T08:35:23Z

Changed mobile template to match laptop template

luixxiul · 2017-12-06T14:45:20Z

wikitemplate.md

+- [ ] Visit https://jsfiddle.net/bkf50r8v/13/, ensure 3 blocked items are listed in shields. Result window should show `got canvas fingerprint 0`  and  `got webgl fingerprint 00`
+- [ ] Visit https://audiofingerprint.openwpm.com/, ensure 2 blocked items are listed in shields. Audio fingerprint graph is shown but doens't contain user fingerprint graph represented in blue line
+
+


nit: remove 1 line.

luixxiul · 2017-12-06T14:47:43Z

wikitemplate-ios.md

+- [ ] Test that PDF is loaded over https at https://basicattentiontoken.org/BasicAttentionTokenWhitePaper-4.pdf
+- [ ] Test that PDF is loaded over http at http://www.pdf995.com/samples/pdf.pdf
+- [ ] Test that https://mixed-script.badssl.com/ shows up as grey not red (no mixed content scripts are run)
+- [ ] Test that https://news.google.com/ sites open in a new tab (due to target being _blank)


mind wrapping _blank with backtick quotes as _ makes something wrapped italic?

kjozwiak · 2017-12-06T14:49:31Z

wikitemplate-ios.md

+- [ ] Test that preferences default Bravery settings take effect on pages with no site settings.
+- [ ] Test that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/7/ when 3rd party cookies are blocked.
+
+**Fingerprinting Tests (Enable fingerprinting protection in Settings)**


Should the iOS mobile templates use the same new FP cases as wikitemplate.md?

Example: got canvas fingerprint 0 and got webgl fingerprint 00

For iOS there is only Canvas check done so the test url is also different compared to laptop. Can add it back later once security team says its the same result for mobile as well.

the changes that @srirambv made to the wiki template recently should probably be reverted since the code change to fingerprinting protection in browser-laptop (brave/browser-laptop#11784) was reverted

kjozwiak · 2017-12-06T14:49:31Z

wikitemplate-android.md

+- [ ] Test that about:preferences default Bravery settings take effect on pages with no site settings.
+- [ ] Test that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/7/ when 3rd party cookies are blocked.
+
+**Fingerprinting Tests (Enable fingerprinting protection in Settings)**


Should the android mobile templates use the same new FP cases as wikitemplate.md?

Example: got canvas fingerprint 0 and got webgl fingerprint 00

@diracdeltas could confirm if the expected result is same for laptop and mobile

srirambv · 2017-12-13T17:43:35Z

Closing in favour of #36

Replace pdf source link

ce84e83

srirambv self-assigned this Nov 27, 2017

srirambv requested review from kjozwiak, luixxiul and LaurenWags Nov 27, 2017

kjozwiak reviewed Nov 27, 2017

View changes

Add pdf http/https links

8e10076

kjozwiak reviewed Nov 27, 2017

View changes

Add pdf http/https to mobile tests

b19dc21

kjozwiak reviewed Nov 27, 2017

View changes

Update iOS with pdf links

550ec65

kjozwiak requested changes Nov 28, 2017

View changes

Added FP tests based on #12121 and fix pdf links

cb9f024

kjozwiak requested changes Dec 5, 2017

View changes

Fix mobile template to match laptop template

2a7242e

luixxiul reviewed Dec 6, 2017

View changes

kjozwiak reviewed Dec 6, 2017

View changes

srirambv closed this Dec 13, 2017

brave / qa-resources

Replace pdf source link #36

Replace pdf source link #36

srirambv commented Nov 27, 2017

kjozwiak left a comment

srirambv commented Nov 27, 2017

kjozwiak left a comment

srirambv commented Nov 27, 2017

kjozwiak left a comment

srirambv commented Nov 28, 2017

This comment has been minimized.

This comment has been minimized.

srirambv commented Nov 29, 2017 •

edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

srirambv commented Dec 6, 2017

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

srirambv commented Dec 13, 2017

		- [ ] Visit https://jsfiddle.net/bkf50r8v/13/, ensure 3 blocked items are listed in shields. Result window should show `got canvas fingerprint 0` and `got webgl fingerprint 00`
		- [ ] Visit https://audiofingerprint.openwpm.com/, ensure 2 blocked items are listed in shields. Audio fingerprint graph is shown but doens't contain user fingerprint graph represented in blue line

brave / qa-resources

Join GitHub today

Replace pdf source link #36

Replace pdf source link #36

Conversation

srirambv commented Nov 27, 2017

kjozwiak left a comment

srirambv commented Nov 27, 2017

kjozwiak left a comment

srirambv commented Nov 27, 2017

kjozwiak left a comment

srirambv commented Nov 28, 2017

This comment has been minimized.

This comment has been minimized.

srirambv commented Nov 29, 2017 • edited

This comment has been minimized.

This comment has been minimized.

kjozwiak Dec 5, 2017 • edited

This comment has been minimized.

kjozwiak Dec 5, 2017 • edited

srirambv commented Dec 6, 2017

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

kjozwiak Dec 6, 2017 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

kjozwiak Dec 6, 2017 • edited

This comment has been minimized.

srirambv commented Dec 13, 2017

srirambv commented Nov 29, 2017 •

edited

kjozwiak Dec 5, 2017 •

edited

kjozwiak Dec 5, 2017 •

edited

kjozwiak Dec 6, 2017 •

edited

kjozwiak Dec 6, 2017 •

edited