Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Windows ia32 tests from test run generator #37

Merged
merged 12 commits into from Dec 13, 2017

Conversation

@srirambv
Copy link
Contributor

srirambv commented Dec 6, 2017

Closes #32

@srirambv srirambv self-assigned this Dec 6, 2017
@srirambv srirambv requested review from kjozwiak and luixxiul Dec 6, 2017
Copy link
Member

kjozwiak left a comment

@srirambv we should probably remove Win32 from braveautogen-pre-release-only.py as well.

@srirambv
Copy link
Contributor Author

srirambv commented Dec 7, 2017

Removed on braveautogen-pre-release-only.py as well.

Copy link
Member

kjozwiak left a comment

Other changes:

  • remove the extra spaces on line 8 and 9 under braveautogen.py.
  • remove the extra space on line 54 under wikitemplate.md (right above ## Sync)

@srirambv other then that, everything looks good! Went through each script and everything was generated without any issues

repo.create_issue(title=wintitle,body=bigline,assignee="luixxiul",milestone=milestone_dictionary[key] ,labels=winlist)

print("Win64 Checklist:")
print("Winx64 Checklist:")

This comment has been minimized.

Copy link
@kjozwiak

kjozwiak Dec 12, 2017

Member

all the other scripts are using Win64 Checklist: but this was changed to Winx64 Checklist:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.