Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded crash,fingerprint and fixed geo location test #47
Conversation
wikitemplate-cr-upgrade.md
Outdated
| @@ -69,6 +69,7 @@ _Each start should take less than 7 seconds_ | |||
| - [ ] opened tabs can be reloaded | |||
| - [ ] bookmarks on the bookmark toolbar can be opened | |||
| - [ ] bookmarks in the bookmark folder toolbar can be opened | |||
| - [ ] ensure upgrade sets fingerprint to `Block all fingerprint` when global fingerprint is enabled | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kjozwiak
Jan 30, 2018
Member
Can you specifically mention 0.19.x -> 0.20.x. After a few 0.20.x hotfixes, we can eventually remove this case as most people would have already migrated from 0.19.x -> 0.20.x.
This comment has been minimized.
This comment has been minimized.
| @@ -56,6 +57,7 @@ | |||
| - [ ] Verify you are able to sync two devices using the secret code | |||
| - [ ] Visit a site on device 1 and change shield setting, ensure that the saved site preference is synced to device 2 | |||
| - [ ] Enable Browsing history sync on device 1, ensure the history is shown on device 2 | |||
| - [ ] Clear browsing history on device 1, ensure the history is sync back on device 1 from device 2 | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srirambv
Jan 30, 2018
Author
Contributor
Yes added it because of brave/sync#182. Not really sure if that is expected or not but since that's been the behaviour added it.
| - [ ] Test that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/9/ when 3rd party cookies are blocked and not blank when 3rd party cookies are unblocked. | ||
| - [ ] Test that audio fingerprint is blocked at https://audiofingerprint.openwpm.com/ when fingerprinting protection is on. | ||
| - [ ] Test that browser is not detected on https://extensions.inrialpes.fr/brave/ | ||
| ### Fingerprint Tests |
This comment has been minimized.
This comment has been minimized.
LaurenWags
Jan 29, 2018
Contributor
Might want to change this to ## Fingerprint Tests to match the other sections.
This comment has been minimized.
This comment has been minimized.
srirambv
Jan 30, 2018
Author
Contributor
Kept it similar to the ledger/media test cases as sub section.
| - [ ] Test that 3rd party storage results are blank at https://jsfiddle.net/7ke9r14a/9/ when 3rd party cookies are blocked and not blank when 3rd party cookies are unblocked. | ||
| - [ ] Test that audio fingerprint is blocked at https://audiofingerprint.openwpm.com/ when fingerprinting protection is on. | ||
| - [ ] Test that browser is not detected on https://extensions.inrialpes.fr/brave/ | ||
| ### Fingerprint Tests |
This comment has been minimized.
This comment has been minimized.
LaurenWags
Jan 29, 2018
Contributor
Same as other, probably want ## Fingerprint Tests for consistency
wikitemplate-cr-upgrade.md
Outdated
| @@ -114,7 +115,15 @@ _Each start should take less than 7 seconds_ | |||
|
|
|||
| ## Geolocation | |||
|
|
|||
| - [ ] Check that https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation works | |||
| - [ ] Check that https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation is blocked due to cross origin iframes | |||
This comment has been minimized.
This comment has been minimized.
wikitemplate-cr-upgrade.md
Outdated
|
|
||
| ## Crash Reporting | ||
|
|
||
| - [ ] Check `chrome://crash` causes the new tab to crash |
This comment has been minimized.
This comment has been minimized.
kjozwiak
Jan 30, 2018
Member
nitpick: "Check that loading chrome://crash causes the new tab to crash"
wikitemplate-cr-upgrade.md
Outdated
| ## Crash Reporting | ||
|
|
||
| - [ ] Check `chrome://crash` causes the new tab to crash | ||
| - [ ] Check `chrome://crashes` lists all the crash with a crash id |
This comment has been minimized.
This comment has been minimized.
kjozwiak
Jan 30, 2018
Member
nitpick: "Check that chrome://crashes lists all the crashes and includes both Crash Report ID & Local Crash ID"
wikitemplate-cr-upgrade.md
Outdated
| - [ ] Check that https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation works | ||
| - [ ] Check that https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation is blocked due to cross origin iframes | ||
| - [ ] Check that https://browserleaks.com/geo works and shows correct location | ||
| - [ ] Check that https://html5demos.com/geo/ works but need not be accurate location |
This comment has been minimized.
This comment has been minimized.
kjozwiak
Jan 30, 2018
Member
nitpick: "Check that https://html5demos.com/geo/ works but doesn't require an accurate location"
Seems like there's a space between that and the URL.
wikitemplate-cr-upgrade.md
Outdated
| ### Fingerprint Tests | ||
| - [ ] Visit https://jsfiddle.net/bkf50r8v/13/, ensure 3 blocked items are listed in shields. Result window should show `got canvas fingerprint 0` and `got webgl fingerprint 00` | ||
| - [ ] Test that audio fingerprint is blocked at https://audiofingerprint.openwpm.com/ only when `Block all fingerprinting protection` is on. | ||
| - [ ] Test that browser is not detected on https://extensions.inrialpes.fr/brave/ |
This comment has been minimized.
This comment has been minimized.
kjozwiak
Jan 30, 2018
Member
nitpick: probably should add "Brave", example: "Test that the Brave browser isn't detected on https://extensions.inrialpes.fr/brave/"
wikitemplate.md
Outdated
| @@ -123,7 +125,15 @@ | |||
|
|
|||
| ## Geolocation | |||
|
|
|||
| - [ ] Check that https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation works | |||
| - [ ] Check that https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation is blocked due to cross origin iframes | |||
This comment has been minimized.
This comment has been minimized.
wikitemplate.md
Outdated
| - [ ] Check that https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation works | ||
| - [ ] Check that https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation is blocked due to cross origin iframes | ||
| - [ ] Check that https://browserleaks.com/geo works and shows correct location | ||
| - [ ] Check that https://html5demos.com/geo/ works but need not be accurate location |
This comment has been minimized.
This comment has been minimized.
kjozwiak
Jan 30, 2018
Member
nitpick: "Check that https://html5demos.com/geo/ works but doesn't require an accurate location"
Seems like there's a space between that and the URL.
wikitemplate.md
Outdated
|
|
||
| ## Crash Reporting | ||
|
|
||
| - [ ] Check `chrome://crash` causes the new tab to crash |
This comment has been minimized.
This comment has been minimized.
kjozwiak
Jan 30, 2018
Member
nitpick: "Check that loading chrome://crash causes the new tab to crash"
wikitemplate.md
Outdated
| ## Crash Reporting | ||
|
|
||
| - [ ] Check `chrome://crash` causes the new tab to crash | ||
| - [ ] Check `chrome://crashes` lists all the crash with a crash id |
This comment has been minimized.
This comment has been minimized.
kjozwiak
Jan 30, 2018
Member
nitpick: "Check that chrome://crashes lists all the crashes and includes both Crash Report ID & Local Crash ID"
wikitemplate.md
Outdated
| ### Fingerprint Tests | ||
| - [ ] Visit https://jsfiddle.net/bkf50r8v/13/, ensure 3 blocked items are listed in shields. Result window should show `got canvas fingerprint 0` and `got webgl fingerprint 00` | ||
| - [ ] Test that audio fingerprint is blocked at https://audiofingerprint.openwpm.com/ only when `Block all fingerprinting protection` is on. | ||
| - [ ] Test that browser is not detected on https://extensions.inrialpes.fr/brave/ |
This comment has been minimized.
This comment has been minimized.
kjozwiak
Jan 30, 2018
Member
nitpick: probably should add "Brave", example: "Test that the Brave browser isn't detected on https://extensions.inrialpes.fr/brave/"
|
Ready for re-review |
wikitemplate-cr-upgrade.md
Outdated
| @@ -69,6 +69,7 @@ _Each start should take less than 7 seconds_ | |||
| - [ ] opened tabs can be reloaded | |||
| - [ ] bookmarks on the bookmark toolbar can be opened | |||
| - [ ] bookmarks in the bookmark folder toolbar can be opened | |||
| - [ ] ensure upgrading from `0.19.x` to `0.20.x` sets fingerprint to `Block all fingerprint` when global fingerprint is enabled | |||
This comment has been minimized.
This comment has been minimized.
wikitemplate.md
Outdated
| @@ -15,6 +15,7 @@ | |||
| - [ ] opened tabs can be reloaded | |||
| - [ ] bookmarks on the bookmark toolbar can be opened | |||
| - [ ] bookmarks in the bookmark folder toolbar can be opened | |||
| - [ ] ensure upgrade sets fingerprint to `Block all fingerprint` when global fingerprint is enabled | |||
This comment has been minimized.
This comment has been minimized.
kjozwiak
Jan 31, 2018
Member
nitpick: should be using the same one as wikitemplate-cr-upgrade.md, example:
"ensure upgrading from 0.19.x to 0.20.x sets fingerprint to Block all fingerprint when global fingerprint is enabled"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
srirambv commentedJan 29, 2018
Fixes #44 #45 #46