Skip to content

/ qa-resources

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wiki templates etc. #5

Closed
wants to merge 2 commits into from
Closed

Update wiki templates etc. #5

wants to merge 2 commits into from

Conversation

@luixxiul
Copy link
Contributor

luixxiul commented Oct 5, 2017

  • Add .editorconfig (same as used on brave/browser-laptop)

Closes #2
Closes #3
Closes #4

Auditors: @alexwykoff

Test Plan:
Suguru Hirahara
Update wiki templates etc.
Unverified
No user is associated with the committer email.
Learn about signing commits
de3005b 
- Add .editorconfig (same as used on brave/browser-laptop)

Closes #2
Closes #3
Closes #4

Auditors: @alexwykoff

Test Plan:
@luixxiul luixxiul added the enhancement label Oct 5, 2017
@luixxiul luixxiul self-assigned this Oct 5, 2017
@luixxiul luixxiul requested review from alexwykoff and kjozwiak Oct 5, 2017
@srirambv

This comment has been minimized.

Sign in to view
Copy link
Contributor

srirambv commented on wikitemplate.md in de3005b Oct 6, 2017

This test would be obsolete with BAT. We will need to clear profile to test wallet creation

This comment has been minimized.

Sign in to view
Copy link
Contributor

luixxiul replied Oct 6, 2017

it should be addressed with #7
@alexwykoff alexwykoff requested review from srirambv, LaurenWags and aekeus Oct 6, 2017
@srirambv
Replaced safebrowing URL
f84aa23
@luixxiul luixxiul closed this Oct 7, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 7, 2017

Opening another PR with the commits from my cloned repo.
@luixxiul luixxiul deleted the update-manual-test-plan branch Oct 7, 2017
@srirambv

This comment has been minimized.

Sign in to view
Copy link
Contributor

srirambv commented on de3005b Oct 10, 2017

For ledger this is test that i'd suggest

## Ledger
- [ ] Verify wallet is auto created after enabling payments
- [ ] Verify monthly budget and account balance shows correct BAT and USD value
- [ ] Verify the wallet overlay is shown when wallet transition is happening upon upgrade 
- [ ] Click on `add funds` and click on each currency and verify it shows wallet address and QR Code
- [ ] Change min visit and min time in advance setting and verify if the publisher list gets updated based on new setting
- [ ] Visit nytimes.com for a few seconds and make sure it shows up in the Payments table.
- [ ] Check that disabling payments and enabling them again does not lose state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aekeus aekeus

@alexwykoff alexwykoff

@kjozwiak kjozwiak

@srirambv srirambv

@LaurenWags LaurenWags

Assignees

@luixxiul luixxiul

Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@luixxiul @srirambv
You can’t perform that action at this time.