Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test sheet v1 #52

Merged
merged 1 commit into from Feb 22, 2018
Merged

Update test sheet v1 #52

merged 1 commit into from Feb 22, 2018

Conversation

@srirambv
Copy link
Contributor

srirambv commented Feb 19, 2018

Fixes #49 & #51

Added WebRTC check link for Android
Moved not implemented items on Android to a separate heading
Moved PDF test to download on Android
Added Browser lock test for iOS
Replaced safe browsing link for iOS and Android
Replaced reader mode link for iOS

@srirambv srirambv self-assigned this Feb 19, 2018
@srirambv srirambv requested review from kjozwiak, LaurenWags and btlechowski Feb 19, 2018
Copy link

btlechowski left a comment

lgtm.
Small thing: PDF tests were moved to Downloads for Android, yet for iOS and Laptop they are in Content tests.

@srirambv
Copy link
Contributor Author

srirambv commented Feb 20, 2018

That was intentional as Android doesn't load pdf in-browser and downloads by default. It satisfies both criteria of Content and Download :)

Copy link
Member

kjozwiak left a comment

lgtm++ Thanks @srirambv!

@kjozwiak kjozwiak merged commit a71524e into brave:master Feb 22, 2018
@srirambv srirambv deleted the srirambv:fixtestsheet branch Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.