Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autofill test case #53

Merged
merged 3 commits into from Mar 19, 2018
Merged

Fix autofill test case #53

merged 3 commits into from Mar 19, 2018

Conversation

@srirambv
Copy link
Contributor

srirambv commented Feb 20, 2018

Fixes: #43

Removed unnecessary . from template and fixed autofill test case

@srirambv srirambv self-assigned this Feb 20, 2018
@srirambv srirambv requested a review from LaurenWags Feb 20, 2018
- [ ] Go to https://brianbondy.com/ and click on the twitter icon on the top right. Test that context menus work in the new twitter tab
- [ ] Load twitter and click on a tweet so the popup div shows. Click to dismiss and repeat with another div. Make sure it shows
- [ ] Go to https://www.bennish.net/web-notifications.html and test that clicking on 'Show' pops up a notification asking for permission. Make sure that clicking 'Deny' leads to no notifications being shown
- [ ] Go to https://trac.torproject.org/projects/tor/login and make sure that the password can be saved. Make sure the saved password shows up in `about:passwords`. Then reload https://trac.torproject.org/projects/tor/login and make sure the saved credentials isn't autofilled instead shows saved id as a dropdown under the login field

This comment has been minimized.

Copy link
@LaurenWags

LaurenWags Mar 19, 2018

Contributor

Nitpick - change "isn't" to "aren't"

@srirambv
Copy link
Contributor Author

srirambv commented Mar 19, 2018

Updated. Ready for merge

@LaurenWags LaurenWags merged commit b849e67 into brave:master Mar 19, 2018
@srirambv srirambv deleted the srirambv:fixautofill branch Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.