Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebRTC fingerprint test #56

Merged
merged 3 commits into from Mar 19, 2018
Merged

Add WebRTC fingerprint test #56

merged 3 commits into from Mar 19, 2018

Conversation

@srirambv
Copy link
Contributor

srirambv commented Mar 16, 2018

Closes #55

@diracdeltas Is the fix available on iOS and Android as well or is it only for laptop?

@srirambv srirambv self-assigned this Mar 16, 2018
@srirambv srirambv requested a review from diracdeltas Mar 16, 2018
Copy link
Member

diracdeltas left a comment

lgtm, i think the fix is also on iOS/Android

@srirambv
Copy link
Contributor Author

srirambv commented Mar 17, 2018

Updated test sheet for all platforms.

Copy link
Member

kjozwiak left a comment

Just need to remove that period from wikitemplate.md

@@ -184,6 +184,7 @@
- [ ] Visit https://jsfiddle.net/bkf50r8v/13/, ensure 3 blocked items are listed in shields. Result window should show `got canvas fingerprint 0` and `got webgl fingerprint 00`
- [ ] Test that audio fingerprint is blocked at https://audiofingerprint.openwpm.com/ only when `Block all fingerprinting protection` is on.

This comment has been minimized.

Copy link
@kjozwiak

kjozwiak Mar 19, 2018

Member

@srirambv lets remove the . from is on. like you did in wikitemplate-cr-upgrade.md

@kjozwiak kjozwiak merged commit 4629772 into brave:master Mar 19, 2018
@srirambv srirambv deleted the srirambv:fptest branch Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.