Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate tests sheet #63
Conversation
| @@ -9,7 +9,7 @@ | |||
| secret_file = open('github.secret', 'r') | |||
| token_string = secret_file.readline().rstrip("\n\r") | |||
|
|
|||
| wiki_file = open('wikitemplate-cr-upgrade.md', 'r') | |||
| wiki_file = open('wikitemplate.md', 'r') | |||
This comment has been minimized.
This comment has been minimized.
kjozwiak
Apr 26, 2018
Member
we'll probably want to remove braveautogen-chromium-upgrade.py as it's basically going to be same thing as braveautogen.py.
| ## Autofill tests | ||
|
|
||
| - [ ] Test that autofill works on http://www.roboform.com/filling-test-all-fields | ||
| - [ ] Verify clicking submit button on a form doesn't crash the browser |
This comment has been minimized.
This comment has been minimized.
kjozwiak
Apr 26, 2018
Member
I'm not seeing a Submit button anywhere on the page. Just a Reset button which isn't crashing 0.22.667. We might want to use one of the examples from known cases that the community has provided us with.
| @@ -228,3 +220,18 @@ Do not forget to make a backup of your entire `~/Library/Application\ Support/Br | |||
|
|
|||
| - [ ] Test that updating using `BRAVE_UPDATE_VERSION=0.8.3` env variable works correctly. | |||
| - [ ] Test that using `BRAVE_ENABLE_PREVIEW_UPDATES=TRUE` env variable works and prompts for preview build updates. | |||
|
|
|||
| # CR Upgrade specific tests | |||
This comment has been minimized.
This comment has been minimized.
kjozwiak
Apr 26, 2018
Member
I don't think we need CR specific tests, we should probably be going through these cases every time we go through a pass. Performance wise, we should be making sure each release hasn't regressed in terms of performance. With the content test, it's easy enough to verify that we could probably add it into the general pass and not place it under CR specific tests. Thoughts @srirambv & @LaurenWags?
| - [ ] Change min visit and min time in advance setting and verify if the publisher list gets updated based on new setting | ||
| - [ ] Visit nytimes.com for a few seconds and make sure it shows up in the Payments table | ||
| - [ ] Check that disabling payments and enabling them again does not lose state | ||
| - [ ] Upgrade from older version |
This comment has been minimized.
This comment has been minimized.
kjozwiak
Apr 26, 2018
Member
We should still test that upgrading from and older version to a newer version works in terms of not losing ledger data, but I don't think we need the cases where we check for overlays/bouncing balls etc. We can change this portion to basically test if an update keeps the ledger intact when updated from a version of Brave that's 2-3 versions back. Thoughts @srirambv & @LaurenWags?
|
|
||
| ## Extensions/Plugins tests | ||
|
|
||
| - [ ] Enable each extension one by one under `about:preferences#extensions` and ensure that the browser doesn't become unresponsive |
This comment has been minimized.
This comment has been minimized.
|
Updated based on review comments. Fixes #64 too |
| - [ ] Visit any live YouTube/Twitch video and ensure the time spent is shown under ledger table | ||
| - [ ] Visit any embeded YouTube/Twitch video and ensure the video publisher name is listed in ledger table | ||
| - [ ] Ensure total time spent is correctly calculated for each publisher video | ||
| - [ ] Ensure total time spent is correctly calculated when switching to YouTube video from an embeded video |
This comment has been minimized.
This comment has been minimized.
kjozwiak
Apr 27, 2018
Member
Should be when switching to YouTube/Twitch video as we're testing embedded Twitch in the following case:
Visit any embeded YouTube/Twitch video and ensure the video publisher name is listed in ledger table
| - [ ] Ensure YouTube/Twitch publishers is listed but not included when `auto-include` is disabled | ||
| - [ ] Update Advanced settings to different time/visit value and ensure YouTube/Twitch videos are added to ledger table once criteria is met | ||
| - [ ] Perform a contribution while YouTube/Twitch channels are included on the ledger. Ensure the channels are listed on the contribution statement | ||
| - [ ] Verify able to delete YouTube/Twitch publishers from ledger table |
This comment has been minimized.
This comment has been minimized.
kjozwiak
Apr 27, 2018
Member
nit: Verify that you are able to delete a YouTube/Twitch publishers from the ledger table
| - [ ] Update Advanced settings to different time/visit value and ensure YouTube/Twitch videos are added to ledger table once criteria is met | ||
| - [ ] Perform a contribution while YouTube/Twitch channels are included on the ledger. Ensure the channels are listed on the contribution statement | ||
| - [ ] Verify able to delete YouTube/Twitch publishers from ledger table | ||
| - [ ] Verify able to re-add YouTube/Twitch publishers to ledger table |
This comment has been minimized.
This comment has been minimized.
kjozwiak
Apr 27, 2018
Member
nit: Verify that you are able to re-add a YouTube/Twitch publishers to the ledger table
|
LGTM |
srirambv commentedApr 26, 2018
Merged Wikitemplate and Wikitemplate-cr-upgrade tests
Fixes #62
added test for reopen closed window keyboard shortcut
fixes #61
Added YT/Twitch test cases
fixes #54
Added muon/chrome checks
fixes #21